From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next] bonding: add option to specify the number of queues per bond device Date: Tue, 05 Nov 2013 16:46:29 +0100 Message-ID: <527912D5.1000209@redhat.com> References: <1383666093-4115-1-git-send-email-nikolay@redhat.com> <52791287.1070101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: andy@greyhouse.net, fubar@us.ibm.com, vfalico@redhat.com To: netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754482Ab3KEPvs (ORCPT ); Tue, 5 Nov 2013 10:51:48 -0500 In-Reply-To: <52791287.1070101@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/05/2013 04:45 PM, Nikolay Aleksandrov wrote: > On 11/05/2013 04:41 PM, Nikolay Aleksandrov wrote: >> Before this patch the only way to specify the number of queues of a bond >> device was to use the tx_queues module parameter on module load. Since >> we can have different setups with different requirements, it's >> beneficial to be able to specify the number of queues per bond device >> creation. This patch adds this ability and uses tx_queues as a default >> and as a fallback in case of an invalid "queues" value. >> The queues are specified when creating a new bond device through sysfs >> by using the ":" as a delimiter between the name and the value, e.g.: >> echo +bond1:8 > bonding_masters >> will create bond1 device with 8 queues. The value 0 is reserved for >> using the default number of queues (global tx_queues set on module >> loading). >> Add an example in the documentation, and also trim a few extra spaces >> and tabs while at it. >> >> Signed-off-by: Nikolay Aleksandrov >> --- > ugh, self-nack I chose the wrong delimiter, it's allowed to be in an interface > name :-) > > Will re-post by using "." as a delimiter. > Sorry for the noise. Again too much caffeine, disregard the "." sentence. > > Nik >