From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfgang Grandegger <wg@grandegger.com>,
netdev@vger.kernel.org, mkl@pengutronix.de,
linux-can@vger.kernel.org
Cc: linux-sh@vger.kernel.org, vksavl@gmail.com
Subject: Re: [PATCH v2] can: add Renesas R-Car CAN driver
Date: Wed, 06 Nov 2013 01:59:26 +0300 [thread overview]
Message-ID: <5279784E.1010205@cogentembedded.com> (raw)
In-Reply-To: <5276A63E.3070505@grandegger.com>
Hello.
On 11/03/2013 10:38 PM, Wolfgang Grandegger wrote:
>>>> Add support for the CAN controller found in Renesas R-Car SoCs.
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> [...]
>>>> Index: linux-can-next/drivers/net/can/rcar_can.c
>>>> ===================================================================
>>>> --- /dev/null
>>>> +++ linux-can-next/drivers/net/can/rcar_can.c
>>>> @@ -0,0 +1,920 @@
>> [...]
>>>> + rcar_can_writeb(priv, RCAR_CAN_ECSR, (u8)~ECSR_ADEF);
>>> Please avoid casts here and below.
>> These casts help avoid compiler warnings.
> Well instead of using casts the declaration of ECSR_ADEF and otheres
> should be fixed. I think the problem is that BIT is declared as shown below:
> #define BIT(nr) (1UL << (nr))
> Using BIT seems not appropriate here.
Well, I thought it was designed to replace explicit (1 << (nr)) #define's.
Hopefully those are good for you then...
> Wolfgang,
WBR, Sergei
next prev parent reply other threads:[~2013-11-05 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 23:03 [PATCH v2] can: add Renesas R-Car CAN driver Sergei Shtylyov
2013-10-25 19:28 ` Wolfgang Grandegger
2013-11-01 22:24 ` Sergei Shtylyov
2013-11-03 19:38 ` Wolfgang Grandegger
2013-11-05 22:59 ` Sergei Shtylyov [this message]
2013-11-06 8:08 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279784E.1010205@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=vksavl@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).