From: John Fastabend <john.r.fastabend@intel.com>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, alexander.h.duyck@intel.com,
andy@greyhouse.net, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, vyasevich@gmail.com
Subject: Re: [net-next PATCH v3 1/2] net: Add layer 2 hardware acceleration operations for macvlan devices
Date: Wed, 06 Nov 2013 10:17:06 -0800 [thread overview]
Message-ID: <527A87A2.1020800@intel.com> (raw)
In-Reply-To: <20131106.030157.1483150214352909742.davem@davemloft.net>
On 11/6/2013 12:01 AM, David Miller wrote:
> From: John Fastabend <john.r.fastabend@intel.com>
> Date: Tue, 05 Nov 2013 15:30:12 -0800
>
>> + /* If we get a NULL pointer back, or if we get an error
>> + * then we should just fall through to the non accelerated path
>> + */
>
> Strange indentation here, two TABs and one SPACE instead of just two
> TABs. Please fix, thanks.
Thanks, fixed in v4.
next prev parent reply other threads:[~2013-11-06 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 23:30 [net-next PATCH v3 0/2] l2 hardware accelerated macvlans John Fastabend
2013-11-05 23:30 ` [net-next PATCH v3 1/2] net: Add layer 2 hardware acceleration operations for macvlan devices John Fastabend
2013-11-06 8:01 ` David Miller
2013-11-06 18:17 ` John Fastabend [this message]
2013-11-05 23:30 ` [net-next PATCH v3 2/2] ixgbe: enable l2 forwarding acceleration for macvlans John Fastabend
2013-11-06 13:59 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527A87A2.1020800@intel.com \
--to=john.r.fastabend@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).