From: Yang Yingliang <yangyingliang@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] net_sched: fix some checkpatch errors
Date: Thu, 7 Nov 2013 09:33:19 +0800 [thread overview]
Message-ID: <527AEDDF.2090102@huawei.com> (raw)
In-Reply-To: <20131106073741.154f8590@samsung-9>
On 2013/11/6 23:37, Stephen Hemminger wrote:
> On Wed, 6 Nov 2013 16:05:08 +0800
> Yang Yingliang <yangyingliang@huawei.com> wrote:
>
>> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>> index fd70728..c8aadfa 100644
>> --- a/net/sched/act_api.c
>> +++ b/net/sched/act_api.c
>> @@ -191,7 +191,7 @@ u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo)
>> val = 1;
>> } while (tcf_hash_lookup(val, hinfo));
>>
>> - return (*idx_gen = val);
>> + return *idx_gen = val;
>
> That is not an improvement. I would rather see the return on a assingment and return
> on separate lines.
>
>
ok, i will fix it in v2.
next prev parent reply other threads:[~2013-11-07 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 8:05 [PATCH net-next 0/3] make tbf support 64bit rates Yang Yingliang
2013-11-06 8:05 ` [PATCH net-next 1/3] net_sched: tbf: support of " Yang Yingliang
2013-11-06 8:05 ` [PATCH net-next 2/3] net_sched: fix some checkpatch errors Yang Yingliang
2013-11-06 15:37 ` Stephen Hemminger
2013-11-07 1:33 ` Yang Yingliang [this message]
2013-11-06 8:05 ` [PATCH net-next 3/3] net_sched: Use pr_debug replace printk(KERN_DEBUG ...) Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527AEDDF.2090102@huawei.com \
--to=yangyingliang@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).