From: Yang Yingliang <yangyingliang@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors
Date: Fri, 8 Nov 2013 09:53:28 +0800 [thread overview]
Message-ID: <527C4418.8010207@huawei.com> (raw)
In-Reply-To: <20131107.191945.629524953531140070.davem@davemloft.net>
On 2013/11/8 8:19, David Miller wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
> Date: Thu, 7 Nov 2013 17:51:57 +0800
>
>> - if (cl->quantum <= 0 || cl->quantum>32*qdisc_dev(cl->qdisc)->mtu) {
>> + if (cl->quantum <= 0 ||
>> + cl->quantum > 32*qdisc_dev(cl->qdisc)->mtu) {
>
> Still not indented properly.
>
> The first character on the second line _MUST_ line up with the first column
> after the openning parenthesis of the if() statement. If you are just
> using TAB characters to ident, you are doing it wrong. You must use
> the correct number of TAB and SPACE characters to reach the goal
> column.
Ok, i will fix it in v4.
Thanks
>
>
next prev parent reply other threads:[~2013-11-08 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 9:51 [PATCH net-next v3 0/2] net_sched: Fix some checkpatch errors and use pr_* Yang Yingliang
2013-11-07 9:51 ` [PATCH net-next v3 1/2] net_sched: fix some checkpatch errors Yang Yingliang
2013-11-08 0:19 ` David Miller
2013-11-08 1:53 ` Yang Yingliang [this message]
2013-11-07 9:51 ` [PATCH net-next v3 2/2] net_sched: Use pr_debug replace printk(KERN_DEBUG ...) Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C4418.8010207@huawei.com \
--to=yangyingliang@huawei.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).