From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangweidong Subject: Re: [PATCH net-next 3/5] sctp: if we done update ssnmap, free the new ssnmap Date: Fri, 8 Nov 2013 12:30:24 +0800 Message-ID: <527C68E0.40602@huawei.com> References: <1383879310-22792-1-git-send-email-wangweidong1@huawei.com> <1383879310-22792-4-git-send-email-wangweidong1@huawei.com> <527C5F3E.3090200@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , , To: Vlad Yasevich , Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:58816 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923Ab3KHEbB (ORCPT ); Thu, 7 Nov 2013 23:31:01 -0500 In-Reply-To: <527C5F3E.3090200@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2013/11/8 11:49, Vlad Yasevich wrote: > On 11/07/2013 09:55 PM, Wang Weidong wrote: >> I found that free the old parameters after update the peer parameters. >> So we should free the new ssnmap which not updated. >> >> Signed-off-by: Wang Weidong >> --- >> net/sctp/associola.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/net/sctp/associola.c b/net/sctp/associola.c >> index 2d53d4c..bca1ad1 100644 >> --- a/net/sctp/associola.c >> +++ b/net/sctp/associola.c >> @@ -1223,6 +1223,10 @@ void sctp_assoc_update(struct sctp_association *asoc, >> } >> } >> >> + /* if we don't update the ssnmap, we should free it. */ >> + if (new->ssnmap) >> + sctp_ssnmap_free(new->ssnmap); >> + >> /* SCTP-AUTH: Save the peer parameters from the new assocaitions >> * and also move the association shared keys over >> */ >> > > Not necessary. This will be done when the 'new' association is destroyed. > > -vlad > Yeah, it is not necessary done in sctp_assoc_update. Thanks. >