From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [patch] net: mv643xx_eth: potential NULL dereference in probe() Date: Wed, 13 Nov 2013 09:24:20 +0100 Message-ID: <52833734.5000507@gmail.com> References: <20131113075247.GI25541@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , Jason Gunthorpe Return-path: In-Reply-To: <20131113075247.GI25541@elgon.mountain> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/13/13 08:52, Dan Carpenter wrote: > We assume that "mp->phy" can be NULL a couple lines before the > dereference. > > Fixes: 1cce16d37d0f ('net: mv643xx_eth: Add missing phy_addr_set in DT mode') > Signed-off-by: Dan Carpenter Acked-by: Sebastian Hesselbarth > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index 00cd36e..e7905d9 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -2890,7 +2890,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev) > PHY_INTERFACE_MODE_GMII); > if (!mp->phy) > err = -ENODEV; > - phy_addr_set(mp, mp->phy->addr); > + else > + phy_addr_set(mp, mp->phy->addr); > } else if (pd->phy_addr != MV643XX_ETH_PHY_NONE) { > mp->phy = phy_scan(mp, pd->phy_addr); > >