From: Vlad Yasevich <vyasevic@redhat.com>
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
"David S . Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net 0/3] bridge: Fix undesirable behavior related to vlan
Date: Wed, 13 Nov 2013 22:14:06 -0500 [thread overview]
Message-ID: <52843FFE.7070202@redhat.com> (raw)
In-Reply-To: <1384331175-4136-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On 11/13/2013 03:26 AM, Toshiaki Makita wrote:
> There seem to be some problems around vlan code.
>
> - Unexpectedly filter vlan by NIC.
> - Not correctly decrement refcount of vlan_vid_info.
> - Memory leak when deleting a bridge with vlan_info allocated.
>
> This is a patch series to fix these issues.
>
> Toshiaki Makita (3):
> bridge: Use vlan_vid_[add/del] instead of direct
> ndo_vlan_rx_[add/kill]_vid calls
> bridge: Call vlan_vid_del for all vids at nbp_vlan_flush
> bridge: Fix memory leak when deleting bridge with vlan filtering
> enabled
>
These all look good to me. Thanks you.
Acked-by: Vlad Yasevich <vyasevic@redhat.com>
-vlad
> net/bridge/br_if.c | 1 +
> net/bridge/br_vlan.c | 24 ++++++++++--------------
> 2 files changed, 11 insertions(+), 14 deletions(-)
>
next prev parent reply other threads:[~2013-11-14 3:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:26 [PATCH net 0/3] bridge: Fix undesirable behavior related to vlan Toshiaki Makita
2013-11-13 8:26 ` [PATCH net 1/3] bridge: Use vlan_vid_[add/del] instead of direct ndo_vlan_rx_[add/kill]_vid calls Toshiaki Makita
2013-11-13 8:26 ` [PATCH net 2/3] bridge: Call vlan_vid_del for all vids at nbp_vlan_flush Toshiaki Makita
2013-11-13 8:26 ` [PATCH net 3/3] bridge: Fix memory leak when deleting bridge with vlan filtering enabled Toshiaki Makita
2013-11-14 3:14 ` Vlad Yasevich [this message]
2013-11-14 21:17 ` [PATCH net 0/3] bridge: Fix undesirable behavior related to vlan David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52843FFE.7070202@redhat.com \
--to=vyasevic@redhat.com \
--cc=davem@davemloft.net \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).