From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH net] bonding: set primary_reselect in LB and AB mode Date: Sat, 16 Nov 2013 12:07:21 +0800 Message-ID: <5286EF79.2080801@gmail.com> References: <5285F130.5060705@huawei.com> <4031.1384538565@death.nxdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ding Tianhong , Andy Gospodarek , "David S. Miller" , Nikolay Aleksandrov , Veaceslav Falico , Netdev To: Jay Vosburgh Return-path: Received: from mail-pd0-f173.google.com ([209.85.192.173]:47503 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353Ab3KPESP (ORCPT ); Fri, 15 Nov 2013 23:18:15 -0500 Received: by mail-pd0-f173.google.com with SMTP id x10so4292808pdj.4 for ; Fri, 15 Nov 2013 20:18:14 -0800 (PST) In-Reply-To: <4031.1384538565@death.nxdomain> Sender: netdev-owner@vger.kernel.org List-ID: =D3=DA 2013/11/16 2:02, Jay Vosburgh =D0=B4=B5=C0: > Ding Tianhong wrote: > >> The primary_reselect only reselection for the primary slave, >> but the primary slave only support for ALB, TLB and AB mode, >> so we sould set the primary_reselect for these mode. >> >> to fix this: Add a check for ALB, TLB and AB mode in >> bonding_store_primary_reselect, avoid to select active slave >> again in other modes. > I don't believe that setting primary_reselect in a > !USES_PRIMARY() mode has any negative effects. It doesn't do anythin= g, > but also doesn't break anything. Is there a case that setting > primary_reselect causes misbehavior in a !USES_PRIMARY() mode? > > Presuming that primary_reselect doesn't break things, this just > adds an ordering limitation when configuring bonding (mode must be se= t > prior to primary_reselect). I don't believe this change adds any val= ue, > and may break existing configuration scripts. > > -J agree, I could not find any problem here, it is not bugfix, so miss it. Regards Ding >> Signed-off-by: Ding Tianhong >> --- >> drivers/net/bonding/bond_sysfs.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/= bond_sysfs.c >> index 47749c9..cac2291 100644 >> --- a/drivers/net/bonding/bond_sysfs.c >> +++ b/drivers/net/bonding/bond_sysfs.c >> @@ -1141,6 +1141,13 @@ static ssize_t bonding_store_primary_reselect= (struct device *d, >> if (!rtnl_trylock()) >> return restart_syscall(); >> >> + if (!USES_PRIMARY(bond->params.mode)) { >> + pr_info("%s: Unable to set primary reselect; %s is in mode %d\n", >> + bond->dev->name, bond->dev->name, bond->params.mode); >> + ret =3D -EINVAL; >> + goto out; >> + } >> + >> new_value =3D bond_parse_parm(buf, pri_reselect_tbl); >> if (new_value < 0) { >> pr_err("%s: Ignoring invalid primary_reselect value %.*s.\n", >> --=20 >> 1.7.12 > --- > -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >