From: Alexander Duyck <alexander.duyck@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH v3] net: Do not include padding in TCP GRO checksum
Date: Sun, 17 Nov 2013 10:24:36 -0800 [thread overview]
Message-ID: <528909E4.1000100@gmail.com> (raw)
In-Reply-To: <20131117031710.GA18254@gondor.apana.org.au>
On 11/16/2013 07:17 PM, Herbert Xu wrote:
> On Sat, Nov 16, 2013 at 09:02:34AM -0800, Alexander Duyck wrote:
>> That being the case though, why don't we set the flush flag on detecting
>> a bad checksum and hand it off to tcp_gro_receive instead of returning
>> NULL? It seems like it would be in our interest to flush the flow and
>> then report the bad checksum instead of keeping the flow and handing off
>> the bad checksum to the stack.
> Because if the TCP checksum is wrong then it may belong to a
> different flow.
>
> Cheers,
It seems like it would be much more likely that a checksum error
occuring with a padded frame would corrupt the flow identifying data
then one that isn't padded.
I suppose it doesn't really matter though since checksum errors are
probably not going to be all that common of a case to deal with anyway.
Thanks,
Alex
next prev parent reply other threads:[~2013-11-17 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 23:00 [PATCH v3] net: Do not include padding in TCP GRO checksum Alexander Duyck
2013-11-16 0:47 ` Herbert Xu
2013-11-16 1:34 ` David Miller
2013-11-16 1:43 ` Herbert Xu
2013-11-16 2:11 ` David Miller
2013-11-16 1:53 ` Herbert Xu
2013-11-16 4:10 ` Alexander Duyck
2013-11-16 6:46 ` Herbert Xu
2013-11-16 7:23 ` Herbert Xu
2013-11-16 17:02 ` Alexander Duyck
2013-11-17 3:17 ` Herbert Xu
2013-11-17 18:24 ` Alexander Duyck [this message]
2013-11-18 0:03 ` Herbert Xu
2013-11-18 17:43 ` Alexander Duyck
2013-11-21 18:35 ` David Miller
2013-11-22 2:30 ` Herbert Xu
2013-11-22 2:31 ` [1/2] gro: Only verify TCP checksums for candidates Herbert Xu
2013-11-22 5:55 ` Eric Dumazet
2013-11-23 22:47 ` David Miller
2013-11-22 2:32 ` [2/2] gro: Clean up tcpX_gro_receive checksum verification Herbert Xu
2013-11-22 5:58 ` Eric Dumazet
2013-11-23 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528909E4.1000100@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).