From: Anton Nayshtut <Anton.Nayshtut@Wilocity.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Veaceslav Falico <vfalico@redhat.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Cong Wang <xiyou.wangcong@gmail.com>,
Nicolas Schichan <nschichan@freebox.fr>,
Eric Dumazet <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Erez Kirshenbaum <Erez.Kirshenbaum@Wilocity.com>,
Boris Lapshin <Boris.Lapshin@Wilocity.com>
Subject: Re: [PATCH 1/4] bonding: L2DA mode added
Date: Mon, 25 Nov 2013 11:10:54 +0200 [thread overview]
Message-ID: <5293141E.5090202@Wilocity.com> (raw)
In-Reply-To: <528E28D7.4010306@redhat.com>
Eric, Nik, Andy,
Thanks for your comments.
I'll investigate the override option approach first, and then will
re-implement the patch using RCU with corresponding
Documentation/networking/bonding.txt changes, if still needed.
P.S. Sorry for delay with my reply. It was caused by personal reasons.
Best Regards,
Anton
On 21/11/2013 17:37, Nikolay Aleksandrov wrote:
> On 11/21/2013 04:32 PM, Eric Dumazet wrote:
>> On Thu, 2013-11-21 at 16:55 +0200, Anton Nayshtut wrote:
>>> This patches introduces L2DA bonding module with all the data structures and
>>> interfaces. It's not integrated yet.
>>
>> I veto any kind of new bonding mode not using RCU.
>>
>> Adding another rwlock in 2013 is simply not an option.
>>
>> Thanks
>>
>>
> +1
> Also,
> I haven't read the patch-set closely but based on the description in the first
> patch I think you can already get this (or very similar) functionality by using
> the slave override option in the bonding. You can match the destination L2
> address and override the slave based on that.
>
> Nik
>
next prev parent reply other threads:[~2013-11-25 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:55 [PATCH 0/4] bonding: L2DA mode Anton Nayshtut
2013-11-21 14:55 ` [PATCH 1/4] bonding: L2DA mode added Anton Nayshtut
2013-11-21 15:32 ` Eric Dumazet
2013-11-21 15:37 ` Nikolay Aleksandrov
2013-11-25 9:10 ` Anton Nayshtut [this message]
2013-11-21 14:55 ` [PATCH 2/4] bonding: L2DA mode intergated Anton Nayshtut
2013-11-21 14:55 ` [PATCH 3/4] bonding: L2DA command IOCTL Anton Nayshtut
2013-11-21 14:55 ` [PATCH 4/4] bonding: L2DA query IOCTL Anton Nayshtut
2013-11-21 15:09 ` [PATCH 0/4] bonding: L2DA mode Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293141E.5090202@Wilocity.com \
--to=anton.nayshtut@wilocity.com \
--cc=Boris.Lapshin@Wilocity.com \
--cc=Erez.Kirshenbaum@Wilocity.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=nschichan@freebox.fr \
--cc=vfalico@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).