netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevich@gmail.com>
To: Mike Rapoport <mike.rapoport@ravellosystems.com>, netdev@vger.kernel.org
Subject: Re: bridge vlan filtering question
Date: Mon, 25 Nov 2013 13:19:40 -0500	[thread overview]
Message-ID: <529394BC.5060805@gmail.com> (raw)
In-Reply-To: <CAF1J0HPkZgiLCY2eiUUWb+t8dJSr2SrUsPtCeHPOxRqU9G6TbA@mail.gmail.com>

On 11/25/2013 02:54 AM, Mike Rapoport wrote:
> Hi all,
> 
> I'm trying to use brigde vlan filtering and I cannot get any traffic
> through the bridge.
> After looking at the code I've noticed that br_get_pvid is always
> returning VLAN_N_VID because VLAN_TAG_PRESENT is never set in the pvid
> field of net_port_vlans.
> Am I missing something or is this an actual bug?
> 

It's a bug.  It's been fixed upstream and has been queued to stable.

commit d1c6c708c4da9d104e0b7c116654cb449bff9b5f
Author: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date:   Wed Oct 16 17:07:15 2013 +0900

    bridge: Fix the way the PVID is referenced


-vlad

  reply	other threads:[~2013-11-25 18:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  7:54 bridge vlan filtering question Mike Rapoport
2013-11-25 18:19 ` Vlad Yasevich [this message]
2013-11-26  9:46   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529394BC.5060805@gmail.com \
    --to=vyasevich@gmail.com \
    --cc=mike.rapoport@ravellosystems.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).