netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* bridge vlan filtering question
@ 2013-11-25  7:54 Mike Rapoport
  2013-11-25 18:19 ` Vlad Yasevich
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Rapoport @ 2013-11-25  7:54 UTC (permalink / raw)
  To: netdev

Hi all,

I'm trying to use brigde vlan filtering and I cannot get any traffic
through the bridge.
After looking at the code I've noticed that br_get_pvid is always
returning VLAN_N_VID because VLAN_TAG_PRESENT is never set in the pvid
field of net_port_vlans.
Am I missing something or is this an actual bug?

-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: bridge vlan filtering question
  2013-11-25  7:54 bridge vlan filtering question Mike Rapoport
@ 2013-11-25 18:19 ` Vlad Yasevich
  2013-11-26  9:46   ` Mike Rapoport
  0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2013-11-25 18:19 UTC (permalink / raw)
  To: Mike Rapoport, netdev

On 11/25/2013 02:54 AM, Mike Rapoport wrote:
> Hi all,
> 
> I'm trying to use brigde vlan filtering and I cannot get any traffic
> through the bridge.
> After looking at the code I've noticed that br_get_pvid is always
> returning VLAN_N_VID because VLAN_TAG_PRESENT is never set in the pvid
> field of net_port_vlans.
> Am I missing something or is this an actual bug?
> 

It's a bug.  It's been fixed upstream and has been queued to stable.

commit d1c6c708c4da9d104e0b7c116654cb449bff9b5f
Author: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date:   Wed Oct 16 17:07:15 2013 +0900

    bridge: Fix the way the PVID is referenced


-vlad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: bridge vlan filtering question
  2013-11-25 18:19 ` Vlad Yasevich
@ 2013-11-26  9:46   ` Mike Rapoport
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2013-11-26  9:46 UTC (permalink / raw)
  To: Vlad Yasevich; +Cc: netdev

On Mon, Nov 25, 2013 at 8:19 PM, Vlad Yasevich <vyasevich@gmail.com> wrote:
> On 11/25/2013 02:54 AM, Mike Rapoport wrote:
>> Hi all,
>>
>> I'm trying to use brigde vlan filtering and I cannot get any traffic
>> through the bridge.
>> After looking at the code I've noticed that br_get_pvid is always
>> returning VLAN_N_VID because VLAN_TAG_PRESENT is never set in the pvid
>> field of net_port_vlans.
>> Am I missing something or is this an actual bug?
>>
>
> It's a bug.  It's been fixed upstream and has been queued to stable.

Thanks a lot.

> commit d1c6c708c4da9d104e0b7c116654cb449bff9b5f
> Author: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> Date:   Wed Oct 16 17:07:15 2013 +0900
>
>     bridge: Fix the way the PVID is referenced
>
>
> -vlad



-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-26  9:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25  7:54 bridge vlan filtering question Mike Rapoport
2013-11-25 18:19 ` Vlad Yasevich
2013-11-26  9:46   ` Mike Rapoport

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).