* [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash
@ 2013-11-26 17:31 Tom Herbert
2013-12-01 12:26 ` Amir Vadai
0 siblings, 1 reply; 2+ messages in thread
From: Tom Herbert @ 2013-11-26 17:31 UTC (permalink / raw)
To: netdev, davem
Drivers should call skb_set_rxhash to set the rxhash and its type
in an skbuff.
Signed-off-by: Tom Herbert <therbert@google.com>
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 07a1d0f..3e48c44 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -747,7 +747,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
}
if (dev->features & NETIF_F_RXHASH)
- gro_skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
+ skb_set_rxhash(gro_skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
skb_record_rx_queue(gro_skb, cq->ring);
@@ -789,7 +789,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
skb_record_rx_queue(skb, cq->ring);
if (dev->features & NETIF_F_RXHASH)
- skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
+ skb_set_rxhash(skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
if ((be32_to_cpu(cqe->vlan_my_qpn) &
MLX4_CQE_VLAN_PRESENT_MASK) &&
--
1.8.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash
2013-11-26 17:31 [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash Tom Herbert
@ 2013-12-01 12:26 ` Amir Vadai
0 siblings, 0 replies; 2+ messages in thread
From: Amir Vadai @ 2013-12-01 12:26 UTC (permalink / raw)
To: Tom Herbert, netdev, davem; +Cc: Hadar Hen Zion
On 26/11/2013 19:31, Tom Herbert wrote:
> Drivers should call skb_set_rxhash to set the rxhash and its type
> in an skbuff.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 07a1d0f..3e48c44 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -747,7 +747,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
> }
>
> if (dev->features & NETIF_F_RXHASH)
> - gro_skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> + skb_set_rxhash(gro_skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>
> skb_record_rx_queue(gro_skb, cq->ring);
>
> @@ -789,7 +789,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
> skb_record_rx_queue(skb, cq->ring);
>
> if (dev->features & NETIF_F_RXHASH)
> - skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> + skb_set_rxhash(skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>
> if ((be32_to_cpu(cqe->vlan_my_qpn) &
> MLX4_CQE_VLAN_PRESENT_MASK) &&
>
I need to do some work in this area of code, but anyway it is not in the
scope of this patchset.
Acked-By: Amir Vadai <amirv@mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-01 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-26 17:31 [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash Tom Herbert
2013-12-01 12:26 ` Amir Vadai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).