From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonio Quartulli Subject: Re: [B.A.T.M.A.N.] [PATCH] Fix ARM BUILD_BUG_ON() errors withbatman-adv Date: Mon, 02 Dec 2013 13:50:46 +0100 Message-ID: <529C8226.2040000@meshcoding.com> References: <20131130191553.GA16735@n2100.arm.linux.org.uk> <529A46C4.9090906@meshcoding.com> <20131130230518.GC16735@n2100.arm.linux.org.uk> <529A8276.9060002@meshcoding.com> <529B47AA.8060403@meshcoding.com> <20131201171309.GD16735@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: The list for a Better Approach To Mobile Ad-hoc Networking , netdev@vger.kernel.org, David Miller To: David Laight , Russell King - ARM Linux Return-path: Received: from s3.neomailbox.net ([178.209.62.157]:46648 "EHLO s3.neomailbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087Ab3LBMvh (ORCPT ); Mon, 2 Dec 2013 07:51:37 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/12/13 11:24, David Laight wrote: > ... >> The only solutions are: use the GCC packed attribute, redesign >> the structures... > > It is probably enough to mark the inner structure containing the > three byte fields 'packed'. Marking it aligned(1) might also have > the desired effect. The outer structure should then be ok. But > would need to use a specially named attribute so it doesn't get > removed. This may work with the structures I reported in a previous email, but it is not a good solution for us because we have other more complex substructs that cannot be packed that way. I think we will simply duplicate the members and avoid substructs in our packets. - -- Antonio Quartulli -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlKcgiYACgkQpGgxIkP9cwfeeQCfef0xDfD2TucJBhzoTmDfwA29 Oc4An3Etz3USDC0cf/+R+Gyx8LEtpq16 =XZn5 -----END PGP SIGNATURE-----