From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH] sctp: disable max_burst when the max_burst is 0 Date: Wed, 04 Dec 2013 09:57:20 +0100 Message-ID: <529EEE70.7090801@redhat.com> References: <529C2E01.3090005@huawei.com> <20131202115640.GA10857@hmsreliant.think-freely.org> <529D7A82.3070207@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Neil Horman , Vlad Yasevich , Michael Tuexen , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, dingtianhong@huawei.com To: Wang Weidong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48656 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754886Ab3LDI5r (ORCPT ); Wed, 4 Dec 2013 03:57:47 -0500 In-Reply-To: <529D7A82.3070207@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On 12/03/2013 07:30 AM, Wang Weidong wrote: > As Michael pointed out that when max_burst is 0, it just disable > max_burst. It declared in rfc6458#section-8.1.24. so add the check > in sctp_transport_burst_limited, when it 0, just do nothing. > > Suggested-by: Vlad Yasevich > Suggested-by: Michael Tuexen > Signed-off-by: Wang Weidong > --- > net/sctp/transport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/transport.c b/net/sctp/transport.c > index e332efb..e580e34 100644 > --- a/net/sctp/transport.c > +++ b/net/sctp/transport.c > @@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t) > u32 old_cwnd = t->cwnd; > u32 max_burst_bytes; > > - if (t->burst_limited) > + /* if the max_burst is 0, do notihing */ > + if (t->burst_limited || !asoc->max_burst) > return; Minor nitpick ... you can remove the comment as it contains a typo and basically says what the code is doing anyway, so you could instead make the code a bit more clear for readers e.g. "asoc->max_burst == 0". > max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu); >