netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevich@gmail.com>
To: Wang Weidong <wangweidong1@huawei.com>,
	nhorman@tuxdriver.com, David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
	Daniel Borkmann <dborkman@redhat.com>
Subject: Re: [PATCH v2] sctp: disable max_burst when the max_burst is 0
Date: Wed, 04 Dec 2013 09:28:03 -0500	[thread overview]
Message-ID: <529F3BF3.40009@gmail.com> (raw)
In-Reply-To: <529EF6B7.7000501@huawei.com>

On 12/04/2013 04:32 AM, Wang Weidong wrote:
> As Michael pointed out that when max_burst is 0, it just disable
> max_burst. It declared in rfc6458#section-8.1.24. so add the check
> in sctp_transport_burst_limited, when it 0, just do nothing.
> 
> Reviewed-by: Daniel Borkmann <dborkman@redhat.com>
> Suggested-by: Vlad Yasevich <vyasevich@gmail.com>
> Suggested-by: Michael Tuexen <Michael.Tuexen@lurchi.franken.de>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
>  net/sctp/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sctp/transport.c b/net/sctp/transport.c
> index e332efb..efc46ff 100644
> --- a/net/sctp/transport.c
> +++ b/net/sctp/transport.c
> @@ -573,7 +573,7 @@ void sctp_transport_burst_limited(struct sctp_transport *t)
>  	u32 old_cwnd = t->cwnd;
>  	u32 max_burst_bytes;
>  
> -	if (t->burst_limited)
> +	if (t->burst_limited || asoc->max_burst == 0)
>  		return;
>  
>  	max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu);
> 

Acked-by: Vlad Yasevich <vyasevich@gmail.com>

Thanks
-vlad

  parent reply	other threads:[~2013-12-04 14:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02  6:51 [PATCH] sctp: make the max_burst min value to 1 Wang Weidong
2013-12-02 11:56 ` Neil Horman
2013-12-02 12:03   ` Wang Weidong
2013-12-02 14:51     ` Vlad Yasevich
2013-12-03  1:35       ` Wang Weidong
2013-12-02 13:08   ` Michael Tuexen
2013-12-03  6:30     ` [PATCH] sctp: disable max_burst when the max_burst is 0 Wang Weidong
2013-12-04  8:57       ` Daniel Borkmann
2013-12-04  9:16         ` Wang Weidong
2013-12-04  9:32 ` [PATCH v2] " Wang Weidong
2013-12-04 11:45   ` Neil Horman
2013-12-04 14:28   ` Vlad Yasevich [this message]
2013-12-06  1:56   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529F3BF3.40009@gmail.com \
    --to=vyasevich@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=wangweidong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).