From: Wang Weidong <wangweidong1@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>, <andrew.hendry@gmail.com>,
<linux-x25@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] x25: convert printks to pr_<level>
Date: Thu, 5 Dec 2013 12:19:00 +0800 [thread overview]
Message-ID: <529FFEB4.2030908@huawei.com> (raw)
In-Reply-To: <1386216573.30493.86.camel@joe-AO722>
On 2013/12/5 12:09, Joe Perches wrote:
> On Thu, 2013-12-05 at 11:06 +0800, Wang Weidong wrote:
>> use pr_<level> instead of printk(LEVEL)
>
> Consider adding
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> or
> #define pr_fmt(fmt) "X25: " fmt
> to each of these files before any #include
> and removing the leading "X25: " in each of
> the formats.
>
Thanks for your suggestions. I will fix it in v2.
Regards.
>
>
>
>
next prev parent reply other threads:[~2013-12-05 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 3:06 [PATCH] x25: convert printks to pr_<level> Wang Weidong
2013-12-05 4:09 ` Joe Perches
2013-12-05 4:19 ` Wang Weidong [this message]
2013-12-05 5:47 ` Yi Li
2013-12-05 6:16 ` Wang Weidong
2013-12-05 6:50 ` [PATCH v2] " Wang Weidong
2013-12-06 11:14 ` Wang Weidong
2013-12-06 11:24 ` [PATCH v3] " Wang Weidong
2013-12-10 1:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529FFEB4.2030908@huawei.com \
--to=wangweidong1@huawei.com \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).