From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH RFCv2 0/6] net: phy: Ethernet PHY powerdown optimization Date: Thu, 5 Dec 2013 13:27:34 +0530 Message-ID: <52A031EE.1040301@ti.com> References: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> <1386171888-28190-1-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , Florian Fainelli , , , To: Sebastian Hesselbarth Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:37461 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722Ab3LEH6G (ORCPT ); Thu, 5 Dec 2013 02:58:06 -0500 In-Reply-To: <1386171888-28190-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wednesday 04 December 2013 09:14 PM, Sebastian Hesselbarth wrote: > This is v2 of an RFC sent earlier [1] to reduce power consumption of network > PHYs with link that are either unused or the corresponding netdev is down. > > In contrast to RFCv1, this now integrates phy_suspend/phy_resume transparent > to the netdev drivers. Also, phy_suspend now only suspends the PHY if WOL is > disabled. Moreover, the phy state machine calls phy_suspend on entering > HALTED state. > > Again, a branch with RFCv2 applied to v3.13-rc2 can also be found at > https://github.com/shesselba/linux-dove.git topic/ethphy-power-rfc-v2 > > [1] http://lwn.net/Articles/574426/ > > Sebastian Hesselbarth (6): > net: mv643xx_eth: properly start/stop phy device > net: phy: marvell: provide genphy suspend/resume > net: phy: provide phy_resume/phy_suspend helpers > net: phy: resume/suspend PHYs on attach/detach > net: phy: suspend unused PHYs on mdio_bus in late_initcall > net: phy: suspend phydev when going to HALTED > > drivers/net/ethernet/marvell/mv643xx_eth.c | 4 +++- > drivers/net/phy/marvell.c | 22 ++++++++++++++++++++++ > drivers/net/phy/mdio_bus.c | 25 +++++++++++++++++++++++++ > drivers/net/phy/phy.c | 6 +++++- > drivers/net/phy/phy_device.c | 27 +++++++++++++++++++++++++++ > include/linux/phy.h | 2 ++ > 6 files changed, 84 insertions(+), 2 deletions(-) > > --- > Cc: David Miller > Cc: Florian Fainelli > Cc: Mugunthan V N > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Apart form Sergei's comment the patch series looks good to me. Acked-by: Mugunthan V N Regards Mugunthan V N