From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Subject: Re: [PATCH v4] sctp: check the rto_min and rto_max Date: Thu, 05 Dec 2013 22:07:37 +0800 Message-ID: <52A088A9.9090200@gmail.com> References: <529FE2AD.5020700@huawei.com> <20131205133217.GA20349@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Vlad Yasevich , David Miller , netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: Neil Horman Return-path: Received: from mail-pb0-f53.google.com ([209.85.160.53]:38201 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699Ab3LEOHX (ORCPT ); Thu, 5 Dec 2013 09:07:23 -0500 In-Reply-To: <20131205133217.GA20349@hmsreliant.think-freely.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Wang Weidong On 2013/12/5 21:32, Neil Horman wrote: > On Thu, Dec 05, 2013 at 10:19:25AM +0800, Wang Weidong wrote: >> rto_min should be smaller than rto_max while rto_max should be larger >> than rto_min. Add two proc_handler for the checking. Add the check in >> sctp_setsockopt_rtoinfo. >> delete a blank line in proc_sctp_do_hmac_alg() declaration. >> >> Suggested-by: Vlad Yasevich >> Signed-off-by: Wang Weidong >> --- >> net/sctp/socket.c | 5 ++++ >> net/sctp/sysctl.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++---- >> 2 files changed, 74 insertions(+), 5 deletions(-) >> >> diff --git a/net/sctp/socket.c b/net/sctp/socket.c >> index 72046b9..2e1af1b 100644 >> --- a/net/sctp/socket.c >> +++ b/net/sctp/socket.c >> @@ -2818,6 +2818,11 @@ static int sctp_setsockopt_rtoinfo(struct sock *sk, char __user *optval, unsigne >> if (copy_from_user(&rtoinfo, optval, optlen)) >> return -EFAULT; >> >> + if (rtoinfo.srto_min < 1 || >> + rtoinfo.srto_max > 86400000 || > These should be defiend to some descriptive value. > Thanks for your suggestion. I will fix it in v5. Regards.