netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: David Laight <David.Laight@ACULAB.COM>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] tcp: auto corking
Date: Fri, 06 Dec 2013 13:34:28 -0800	[thread overview]
Message-ID: <52A242E4.2090304@hp.com> (raw)
In-Reply-To: <52A1F603.2030208@hp.com>

On 12/06/2013 08:06 AM, Rick Jones wrote:
> I was wondering why Nagle didn't catch these things as well.  The
> netperf command line Eric provided though didn't include the
> test-specific -D option that would have disabled Nagle.  At least not
> unless the "super_netperf" wrapper was adding it.
>
> So, why doesn't Nagle catch what is presumably a sub-MSS send while
> there is data outstanding on the connection?

Because this is operating "above" (as it were) Nagle and is looking only 
to try to get the successive small sends into a smaller number of skbs 
yes? So that when there is either no data outstanding, or an MSS's worth 
of data it will be in a small(ish) number of skbs not a long chain of them.

rick jones

  parent reply	other threads:[~2013-12-06 21:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06  6:36 [PATCH net-next] tcp: auto corking Eric Dumazet
2013-12-06 10:30 ` David Laight
2013-12-06 16:06   ` Rick Jones
2013-12-06 16:30     ` David Laight
2013-12-06 17:46     ` Eric Dumazet
2013-12-06 17:57       ` David Laight
2013-12-06 18:02       ` Rick Jones
2013-12-06 18:36         ` Eric Dumazet
2013-12-06 21:34     ` Rick Jones [this message]
2013-12-06 17:54 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A242E4.2090304@hp.com \
    --to=rick.jones2@hp.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).