From: Gao feng <gaofeng@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] vxlan: remove vxlan_group_used in vxlan_open
Date: Tue, 10 Dec 2013 14:26:30 +0800 [thread overview]
Message-ID: <52A6B416.7@cn.fujitsu.com> (raw)
In-Reply-To: <20131209.193244.2227545675987687506.davem@davemloft.net>
On 12/10/2013 08:32 AM, David Miller wrote:
> From: Gao feng <gaofeng@cn.fujitsu.com>
> Date: Thu, 5 Dec 2013 17:01:35 +0800
>
>> In vxlan_open, vxlan_group_used always returns true,
>> because the state of the vxlan deivces which we want
>> to open has alreay been running. and it has already
>> in vxlan_list.
>>
>> Since ip_mc_join_group takes care of the reference
>> problem. we can remove vxlan_group_used here, let
>> ip_mc_join_group resolve the reference problem.
>>
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>
> "already" is misspelled in this commit message.
>
> Please describe what "the reference problem" actually is.
>
There is no reference bug here. just means we needn't to take
care of the reference of ip_mc_list, vxlan_group_used has no use here.
>> @@ -1943,8 +1943,7 @@ static int vxlan_open(struct net_device *dev)
>> if (!vs)
>> return -ENOTCONN;
>>
>> - if (vxlan_addr_multicast(&vxlan->default_dst.remote_ip) &&
>> - vxlan_group_used(vn, &vxlan->default_dst.remote_ip)) {
>> + if (vxlan_addr_multicast(&vxlan->default_dst.remote_ip)) {
>
> This makes "vn" unused, please remove it.
>
> The compiler even warns about this, are you watching the build
> after making changes for messages like that?
Sorry for this. I will take care of this.
Thanks!
prev parent reply other threads:[~2013-12-10 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 9:01 [PATCH 1/2] vxlan: remove vxlan_group_used in vxlan_open Gao feng
2013-12-05 9:01 ` [PATCH 2/2] vxlan: leave multicast group when vxlan device down Gao feng
2013-12-10 0:32 ` [PATCH 1/2] vxlan: remove vxlan_group_used in vxlan_open David Miller
2013-12-10 6:26 ` Gao feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6B416.7@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).