From: Daniel Borkmann <dborkman@redhat.com>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v6 0/3] sctp: check the rto_min and rto_max
Date: Tue, 10 Dec 2013 13:51:04 +0100 [thread overview]
Message-ID: <52A70E38.9020906@redhat.com> (raw)
In-Reply-To: <1386643597-22156-1-git-send-email-wangweidong1@huawei.com>
On 12/10/2013 03:46 AM, Wang Weidong wrote:
> v5 -> v6
> -patch1: do rto_min/max socket option handling in its own patch, and
> fix the check of rto_min/max.
> -patch2: do rto_min/max sysctl handling in its own patch.
> -patch3: add Suggested-by Daniel.
Fyi, for future submission, please keep the full changelog.
I would have much rather liked seeing you with finishing the last
2 patches first, and then approach the newly introduced 1st one
in this series for now. You still haven't fully fixed whitespace
issues in your second patch in the function itself which I hoped
you would address, but fair enough ...
> Wang Weidong (3):
> sctp: check the rto_min and rto_max in setsockopt
> sctp: add check rto_min and rto_max in sysctl
> sctp: fix up a spacing
>
> net/sctp/socket.c | 32 +++++++++++++++--------
> net/sctp/sysctl.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++-------
> 2 files changed, 89 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2013-12-10 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 2:46 [PATCH v6 0/3] sctp: check the rto_min and rto_max Wang Weidong
2013-12-10 2:46 ` [PATCH v6 1/3] sctp: check the rto_min and rto_max in setsockopt Wang Weidong
2013-12-10 2:46 ` [PATCH v6 2/3] sctp: add check rto_min and rto_max in sysctl Wang Weidong
2013-12-10 14:34 ` Vlad Yasevich
2013-12-10 15:18 ` Wang Weidong
2013-12-10 15:21 ` Daniel Borkmann
2013-12-10 15:42 ` Wang Weidong
2013-12-10 2:46 ` [PATCH v6 3/3] sctp: fix up a spacing Wang Weidong
2013-12-10 12:51 ` Daniel Borkmann [this message]
2013-12-10 14:34 ` [PATCH v6 0/3] sctp: check the rto_min and rto_max Wang Weidong
2013-12-10 14:38 ` Vlad Yasevich
2013-12-10 15:24 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A70E38.9020906@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).