From: Wang Weidong <weidong1991.wang@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
nhorman@tuxdriver.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v6 2/3] sctp: add check rto_min and rto_max in sysctl
Date: Tue, 10 Dec 2013 23:42:37 +0800 [thread overview]
Message-ID: <52A7366D.4090309@gmail.com> (raw)
In-Reply-To: <52A73167.6000106@redhat.com>
On 2013/12/10 23:21, Daniel Borkmann wrote:
> On 12/10/2013 04:18 PM, Wang Weidong wrote:
> ...
>>>> +static int proc_sctp_do_rto_min(struct ctl_table *ctl, int write,
>>>> + void __user*buffer, size_t *lenp,
>>> ^^^^
>>> Please put a space before the '*'.
> ...
>>>> +static int proc_sctp_do_rto_max(struct ctl_table *ctl, int write,
>>>> + void __user*buffer, size_t *lenp,
>>> ^^^^
>>> Please put a space after the before the '*'.
>>>
>> Ok, I will fix them.
>> What Daniel point out is that? I no need to line up them?
>
> Yes, what Vlad pointed out to you is what I meant in my reply to
> your cover letter ...
Nice. I get it.
Thanks.
next prev parent reply other threads:[~2013-12-10 15:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 2:46 [PATCH v6 0/3] sctp: check the rto_min and rto_max Wang Weidong
2013-12-10 2:46 ` [PATCH v6 1/3] sctp: check the rto_min and rto_max in setsockopt Wang Weidong
2013-12-10 2:46 ` [PATCH v6 2/3] sctp: add check rto_min and rto_max in sysctl Wang Weidong
2013-12-10 14:34 ` Vlad Yasevich
2013-12-10 15:18 ` Wang Weidong
2013-12-10 15:21 ` Daniel Borkmann
2013-12-10 15:42 ` Wang Weidong [this message]
2013-12-10 2:46 ` [PATCH v6 3/3] sctp: fix up a spacing Wang Weidong
2013-12-10 12:51 ` [PATCH v6 0/3] sctp: check the rto_min and rto_max Daniel Borkmann
2013-12-10 14:34 ` Wang Weidong
2013-12-10 14:38 ` Vlad Yasevich
2013-12-10 15:24 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A7366D.4090309@gmail.com \
--to=weidong1991.wang@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).