From: Denys Vlasenko <dvlasenk@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
jpirko@redhat.com
Subject: Re: [patch net-next v2] ipv6: log autoconfiguration failures
Date: Thu, 12 Dec 2013 12:28:16 +0100 [thread overview]
Message-ID: <52A99DD0.9030007@redhat.com> (raw)
In-Reply-To: <20131211.155452.558417595732985707.davem@davemloft.net>
On 12/11/2013 09:54 PM, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Date: Wed, 11 Dec 2013 20:21:38 +0100
>
>> On Wed, Dec 11, 2013 at 12:45:14PM +0100, Denys Vlasenko wrote:
>>> If ipv6 auto-configuration does not work, currently it's hard
>>> to track what's going on. This change adds log messages
>>> (at debug level) on every code path where ipv6 autoconf fails.
>>>
>>> v2: fixed indentation in multi-line log output statements.
>>
>> Have you seen lots of those problems? Some of those seem like very
>> serious problems and maybe could also deserve a pr_warn or pr_err.
>>
>> I hope these are one-time errors, so I don't think counters would
>> be helpful.
>
> I still think that statitics would better serve this issue.
>
> You can make them part of the per-inet6_dev MIB, and therefore
> implicitly letting the admin know what interface the events
> occurred on.
Putting myself in admin's boots...
Admins want to know why ipv6 autoconf didn't work, not so much
how many times it didn't work. This requires a text message.
> For one thing, the event would always be counted, whereas with
> pr_debug() someone has to turn on dynamic debugging in order
> to see the message.
Point taken wrt pr_debug being too gentle.
I should have used pr_warn or at least pr_info...
--
vda
next prev parent reply other threads:[~2013-12-12 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 11:45 [patch net-next v2] ipv6: log autoconfiguration failures Denys Vlasenko
2013-12-11 19:21 ` Hannes Frederic Sowa
2013-12-11 20:54 ` David Miller
2013-12-11 21:09 ` Hannes Frederic Sowa
2013-12-12 11:28 ` Denys Vlasenko [this message]
2013-12-12 17:24 ` David Miller
2013-12-12 11:17 ` Denys Vlasenko
2013-12-12 17:22 ` David Miller
2013-12-12 17:58 ` Vlad Yasevich
2013-12-12 18:24 ` David Miller
2013-12-12 19:00 ` Hannes Frederic Sowa
2013-12-12 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A99DD0.9030007@redhat.com \
--to=dvlasenk@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).