From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, bhutchings@solarflare.com,
blaschka@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/2] Display adjacent switch port's attributes
Date: Thu, 12 Dec 2013 14:57:18 +0100 [thread overview]
Message-ID: <52A9C0BE.5090801@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131211121357.4742d9e8@nehalam.linuxnetplumber.net>
Am 11.12.2013 21:13, schrieb Stephen Hemminger:
> On Wed, 11 Dec 2013 14:28:58 +0100
> Stefan Raspl <raspl@linux.vnet.ibm.com> wrote:
>
>> This patch series adds a new callback for ethtool to display the adjacent switch
>> port's attributes, as perceived by the NIC, e.g. through respective LLDP message
>> exchanges.
>> A patch for the qeth device driver provides a sample exploiter for the new
>> functionality.
>> A new option for ethtool to display the settings will be posted in a separate
>> patch.
>>
>> Best regards,
>> Stefan Raspl
>>
>> Stefan Raspl (2):
>> ethtool: Add callback to indicate adjacent switch port attributes
>> qeth: Display adjacent switch port attributes in ethtool
>>
>> drivers/s390/net/qeth_core.h | 7 ++++
>> drivers/s390/net/qeth_core_main.c | 79 +++++++++++++++++++++++++++++++++++++++
>> drivers/s390/net/qeth_core_mpc.h | 17 +++++++++
>> drivers/s390/net/qeth_l2_main.c | 1 +
>> drivers/s390/net/qeth_l3_main.c | 1 +
>> include/linux/ethtool.h | 3 ++
>> include/uapi/linux/ethtool.h | 35 +++++++++++++++++
>> net/core/ethtool.c | 22 +++++++++++
>> 8 files changed, 165 insertions(+)
>>
>
> Why more ethtool and not netlink? ethtool is a brittle interface, non-extensible
> and does not support notifications of changes.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I agree, netlink would certainly be nice. But ethtool is the
de-facto standard for now, and there doesn't seem to be a
netlink-based alternative in sight - or is there?
Offering a netlink based tool seems to be a different discussion,
and if that takes shape, existing ethtool functionality (including
this series) can and should be migrated.
next prev parent reply other threads:[~2013-12-12 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 13:28 [PATCH 0/2] Display adjacent switch port's attributes Stefan Raspl
2013-12-11 13:28 ` [PATCH 1/2] ethtool: Add callback to indicate adjacent switch port attributes Stefan Raspl
2013-12-11 13:29 ` [PATCH 2/2] qeth: Display adjacent switch port attributes in ethtool Stefan Raspl
2013-12-11 20:13 ` [PATCH 0/2] Display adjacent switch port's attributes Stephen Hemminger
2013-12-12 10:06 ` Nicolas Dichtel
2013-12-12 13:57 ` Stefan Raspl [this message]
2013-12-12 17:28 ` David Miller
2013-12-12 17:52 ` John Fastabend
2013-12-12 19:03 ` Florian Fainelli
2013-12-12 21:47 ` John Fastabend
2013-12-12 22:00 ` Ben Hutchings
2013-12-16 15:32 ` Stefan Raspl
2014-01-07 14:28 ` Stefan Raspl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9C0BE.5090801@linux.vnet.ibm.com \
--to=raspl@linux.vnet.ibm.com \
--cc=bhutchings@solarflare.com \
--cc=blaschka@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).