netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ipv6: fix incorrect type in initializer
@ 2013-12-12 10:41 Florent Fourcot
  2013-12-12 14:36 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Florent Fourcot @ 2013-12-12 10:41 UTC (permalink / raw)
  To: netdev; +Cc: Florent Fourcot

Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
  "ipv6: add flowinfo for tcp6 pkt_options for all cases"

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
---
 net/ipv6/ipv6_sockglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
index bc4d8a2..dac04d2 100644
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -1035,7 +1035,7 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
 				put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
 			}
 			if (np->rxopt.bits.rxflow) {
-				int flowinfo = np->rcv_flowinfo;
+				__be32 flowinfo = np->rcv_flowinfo;
 				put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);
 			}
 		}
-- 
1.8.5.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipv6: fix incorrect type in initializer
  2013-12-12 10:41 [PATCH] ipv6: fix incorrect type in initializer Florent Fourcot
@ 2013-12-12 14:36 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2013-12-12 14:36 UTC (permalink / raw)
  To: Florent Fourcot, netdev

Hello.

On 12-12-2013 14:41, Florent Fourcot wrote:

    s/initializer/declaration/.

> Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
>    "ipv6: add flowinfo for tcp6 pkt_options for all cases"

> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
> ---
>   net/ipv6/ipv6_sockglue.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
> index bc4d8a2..dac04d2 100644
> --- a/net/ipv6/ipv6_sockglue.c
> +++ b/net/ipv6/ipv6_sockglue.c
> @@ -1035,7 +1035,7 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
>   				put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
>   			}
>   			if (np->rxopt.bits.rxflow) {
> -				int flowinfo = np->rcv_flowinfo;
> +				__be32 flowinfo = np->rcv_flowinfo;

    Empty line wouldn't hurt here, after declaration.

>   				put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);

WBR, Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-12 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-12 10:41 [PATCH] ipv6: fix incorrect type in initializer Florent Fourcot
2013-12-12 14:36 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).