netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.r.fastabend@intel.com>
To: raspl@linux.vnet.ibm.com
Cc: David Miller <davem@davemloft.net>,
	stephen@networkplumber.org, bhutchings@solarflare.com,
	blaschka@linux.vnet.ibm.com, netdev@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/2] Display adjacent switch port's attributes
Date: Thu, 12 Dec 2013 09:52:13 -0800	[thread overview]
Message-ID: <52A9F7CD.5050904@intel.com> (raw)
In-Reply-To: <20131212.122801.1249371766101769652.davem@davemloft.net>

On 12/12/2013 9:28 AM, David Miller wrote:
> From: Stefan Raspl <raspl@linux.vnet.ibm.com>
> Date: Thu, 12 Dec 2013 14:57:18 +0100
>
>> I agree, netlink would certainly be nice. But ethtool is the
>> de-facto standard for now, and there doesn't seem to be a
>> netlink-based alternative in sight - or is there?
>> Offering a netlink based tool seems to be a different discussion,
>> and if that takes shape, existing ethtool functionality (including
>> this series) can and should be migrated.
>
> I completely disagree, ethtool is not de-facto for anything in
> particular.  It's suitable for some things, not suitable for
> others.
>
> And just because it's used for other aspects of a device's
> configuration doesn't mean that netlink isn't appropriate for other
> apsects.

Just to elaborate...

Any application using lldp information will want to get events when
TLVs change. Maybe you can contrive ethtool to do this but its going to
be ugly. Netlink can support multicast events and applications can
register for them. Also netlink's TLV format matches nicely with LLDPs
TLV format.

If you push an ethtool interface now we get stuck with an interface
that is only useful in a very narrow use case. And netlink interfaces
are relatively easy to construct so lets do this right the first time.
I also happen to maintain lldpad and would be happy to plug in support
for this via netlink so we can push firmware and software based agent
LLDP info up to libvirt/network manager whatever in a consistent way.
Similarly other existing lldp agents could do the same.

Thanks,
.John

  reply	other threads:[~2013-12-12 17:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 13:28 [PATCH 0/2] Display adjacent switch port's attributes Stefan Raspl
2013-12-11 13:28 ` [PATCH 1/2] ethtool: Add callback to indicate adjacent switch port attributes Stefan Raspl
2013-12-11 13:29 ` [PATCH 2/2] qeth: Display adjacent switch port attributes in ethtool Stefan Raspl
2013-12-11 20:13 ` [PATCH 0/2] Display adjacent switch port's attributes Stephen Hemminger
2013-12-12 10:06   ` Nicolas Dichtel
2013-12-12 13:57   ` Stefan Raspl
2013-12-12 17:28     ` David Miller
2013-12-12 17:52       ` John Fastabend [this message]
2013-12-12 19:03         ` Florian Fainelli
2013-12-12 21:47           ` John Fastabend
2013-12-12 22:00             ` Ben Hutchings
2013-12-16 15:32             ` Stefan Raspl
2014-01-07 14:28               ` Stefan Raspl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A9F7CD.5050904@intel.com \
    --to=john.r.fastabend@intel.com \
    --cc=bhutchings@solarflare.com \
    --cc=blaschka@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=raspl@linux.vnet.ibm.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).