From: Daniel Borkmann <dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH net-next v2 1/2] lib: introduce arch optimized hash library
Date: Thu, 12 Dec 2013 19:04:14 +0100 [thread overview]
Message-ID: <52A9FA9E.6090604@redhat.com> (raw)
In-Reply-To: <52A9F84F.8060500-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
On 12/12/2013 06:54 PM, Nicolas Dichtel wrote:
...
> Is it possible to trace that this comes from the DPDK?
> At least in the commit log, like it was done in the v1.
Hm, that got lost; but we can put that back into the commit log.
In any case, we properly included the header comment, of course.
>> +static inline u32 crc32_u32(u32 crc, u32 val)
>> +{
>> + asm ("crc32l %1,%0\n" : "+r" (crc) : "rm" (val));
> I'm not an expert, but is it not possible to use intrisics functions, like it is
> done in the original code?
Intrinsics are not used/available in the kernel, so we used asm
as everywhere else.
next prev parent reply other threads:[~2013-12-12 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 15:09 [PATCH net-next v2 0/2] ovs: introduce arch-specific fast hashing improvements Francesco Fusco
2013-12-12 15:09 ` [PATCH net-next v2 2/2] net: ovs: use CRC32 accelerated flow hash if available Francesco Fusco
2013-12-12 20:20 ` Jesse Gross
2013-12-13 9:55 ` Francesco Fusco
2013-12-13 21:12 ` Jesse Gross
[not found] ` <CAEP_g=-JBT_XVvwSa4xOwVoTysoL0Z8zJc-ERSHJc96+qrA99Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-13 10:01 ` David Laight
2013-12-13 14:53 ` Francesco Fusco
2013-12-12 21:12 ` [PATCH net-next v2 0/2] ovs: introduce arch-specific fast hashing improvements David Miller
[not found] ` <1386860946-1621-1-git-send-email-ffusco-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-12 15:09 ` [PATCH net-next v2 1/2] lib: introduce arch optimized hash library Francesco Fusco
2013-12-12 17:54 ` Nicolas Dichtel
[not found] ` <52A9F84F.8060500-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-12-12 18:04 ` Daniel Borkmann [this message]
2013-12-17 19:28 ` [PATCH net-next v2 0/2] ovs: introduce arch-specific fast hashing improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9FA9E.6090604@redhat.com \
--to=dborkman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).