From: Fan Du <fan.du@windriver.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: David Miller <davem@davemloft.net>,
<steffen.klassert@secunet.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCHv2 net-next 0/5] pktgen IPsec support
Date: Fri, 13 Dec 2013 16:56:24 +0800 [thread overview]
Message-ID: <52AACBB8.4060009@windriver.com> (raw)
In-Reply-To: <52A86BBE.1090408@mojatatu.com>
FWIW, I will follow Dave's suggestion not to touch your original
support at the first place no matter how below answer looks like.
On 2013年12月11日 21:42, Jamal Hadi Salim wrote:
> On 12/09/13 20:23, David Miller wrote:
>
>> Maybe they didn't care about the checksum being correct in the
>> testbed they were using.
>
> Thats correct. The point is to exercise the crypto code.
> Please dont change this.
However exercising crypto engine on host running pktgen does *NOT* necessary
requiring bad IP checksum value and wrong total len value, because encryption
has been done.
I'm confused here with your test rationale, and what's wrong to use
the right checksum/total length value? Please clear my puzzles.
Thanks
--
浮沉随浪只记今朝笑
--fan
next prev parent reply other threads:[~2013-12-13 8:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:53 [PATCHv2 net-next 0/5] pktgen IPsec support Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 1/5] {pktgen, xfrm} Remove original pktgen ipsec fixed configuration Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 2/5] {pktgen, xfrm} Using "pgset spi xxx" to spedifiy SA for a given flow Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 3/5] {pktgen,xfrm} Construct skb dst for tunnel mode transformation Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 4/5] {pktgen, xfrm} Introduce xfrm_state_lookup_byspi for pktgen Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 5/5] {pktgen, xfrm} Correct xfrm state lock usage when transforming Fan Du
2013-12-10 0:58 ` [PATCHv2 net-next 0/5] pktgen IPsec support David Miller
2013-12-10 1:19 ` Fan Du
2013-12-10 1:23 ` David Miller
2013-12-10 2:02 ` Fan Du
2013-12-10 2:09 ` David Miller
2013-12-10 2:27 ` Fan Du
2013-12-10 5:49 ` David Miller
2013-12-11 13:42 ` Jamal Hadi Salim
2013-12-13 8:56 ` Fan Du [this message]
2013-12-13 12:13 ` Jamal Hadi Salim
2013-12-13 12:22 ` Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AACBB8.4060009@windriver.com \
--to=fan.du@windriver.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).