* [PATCH net-next 2/6] mac80211: slight optimization of addr compare
@ 2013-12-16 7:15 Ding Tianhong
2013-12-16 7:47 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Ding Tianhong @ 2013-12-16 7:15 UTC (permalink / raw)
To: Johannes Berg, John W. Linville, David S. Miller, Netdev,
Joe Perches
Joe Perches add ether_addr_equal_unaligned to test if
possibly unaligned to u16 Ethernet addresses are equal.
If CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set, this uses
the slightly faster generic routine ether_addr_equal,
otherwise this uses memcmp.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
net/mac80211/iface.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 7aa9f9d..be95eb7 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1497,8 +1497,8 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
bool used = false;
list_for_each_entry(sdata, &local->interfaces, list) {
- if (memcmp(local->hw.wiphy->addresses[i].addr,
- sdata->vif.addr, ETH_ALEN) == 0) {
+ if (ether_addr_equal_unaligned(sdata->vif.addr,
+ local->hw.wiphy->addresses[i].addr)) {
used = true;
break;
}
@@ -1558,8 +1558,8 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
val += inc;
list_for_each_entry(sdata, &local->interfaces, list) {
- if (memcmp(tmp_addr, sdata->vif.addr,
- ETH_ALEN) == 0) {
+ if (ether_addr_equal_unaligned(tmp_addr,
+ sdata->vif.addr)) {
used = true;
break;
}
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 2/6] mac80211: slight optimization of addr compare
2013-12-16 7:15 [PATCH net-next 2/6] mac80211: slight optimization of addr compare Ding Tianhong
@ 2013-12-16 7:47 ` Johannes Berg
2013-12-16 8:04 ` Ding Tianhong
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2013-12-16 7:47 UTC (permalink / raw)
To: Ding Tianhong; +Cc: John W. Linville, David S. Miller, Netdev, Joe Perches
On Mon, 2013-12-16 at 15:15 +0800, Ding Tianhong wrote:
> - sdata->vif.addr, ETH_ALEN) == 0) {
> + if (ether_addr_equal_unaligned(sdata->vif.addr,
> + local->hw.wiphy->addresses[i].addr)) {
Your indentation is terrible, I'm not applying this.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 2/6] mac80211: slight optimization of addr compare
2013-12-16 7:47 ` Johannes Berg
@ 2013-12-16 8:04 ` Ding Tianhong
0 siblings, 0 replies; 3+ messages in thread
From: Ding Tianhong @ 2013-12-16 8:04 UTC (permalink / raw)
To: Johannes Berg; +Cc: John W. Linville, David S. Miller, Netdev, Joe Perches
On 2013/12/16 15:47, Johannes Berg wrote:
> On Mon, 2013-12-16 at 15:15 +0800, Ding Tianhong wrote:
>
>> - sdata->vif.addr, ETH_ALEN) == 0) {
>> + if (ether_addr_equal_unaligned(sdata->vif.addr,
>> + local->hw.wiphy->addresses[i].addr)) {
>
> Your indentation is terrible, I'm not applying this.
>
> johannes
>
ok, I'll fix it.
Ding
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-16 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 7:15 [PATCH net-next 2/6] mac80211: slight optimization of addr compare Ding Tianhong
2013-12-16 7:47 ` Johannes Berg
2013-12-16 8:04 ` Ding Tianhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox