netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <j.hadi123@gmail.com>
To: Fan Du <fan.du@windriver.com>, Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, steffen.klassert@secunet.com,
	hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [PATCHv3 net-next 0/7] pktgen IPsec support
Date: Tue, 17 Dec 2013 08:41:22 -0500	[thread overview]
Message-ID: <52B05482.7030400@gmail.com> (raw)
In-Reply-To: <52AFB580.5060403@windriver.com>

On 12/16/13 21:22, Fan Du wrote:
>
>
> I thought we have reach the consensus on this part in previous discussion
> (http://www.spinics.net/lists/netdev/msg261411.html), This enhancement
> patch didn't change original behavior, nor does remove original 
> implementation.
>

right - thats the agreement. i.e nothing changes by default unless
some pktgen parameter is set.
If someone wants to send using original scheme it should work
as long as they dont set this extra parameter.

> This enhancement expects good encapsulation format for the receiver to
> de-encapsulation.
>

Maybe i missed something - receiver wasnt affected in the discussion.
It was only the sender.

> This is snippets of doc updates I could come up with. Please check if 
> it's ok
> for you.
>
> @@ -108,7 +108,9 @@ Examples:
>                                MPLS_RND, VID_RND, SVID_RND
>                                QUEUE_MAP_RND # queue map random
>                                QUEUE_MAP_CPU # queue map mirrors 
> smp_processor_id()
> +                              IPSEC # Make IPsec encapsulation for 
> packet
>
> + pgset spi SPI_VALUE     Set specific SA used to transform packet.
>
>   pgset "udp_src_min 9"   set UDP source port min, If < udp_src_max, then
>                           cycle through the port range.
> @@ -177,6 +179,18 @@ Note when adding devices to a specific CPU there 
> good idea to also assign
>  /proc/irq/XX/smp_affinity so the TX-interrupts gets bound to the same 
> CPU.
>  as this reduces cache bouncing when freeing skb's.
>
> +Enable IPsec
> +============
> +Default IPsec transformation with ESP encapsulation plus Transport mode
> +could be enabled by simply setting:
> +
> +pgset "flag IPSEC"
> +pgset "flows 1"
> +
> +To avoid breaking existing testbed scripts for using AH type and 
> tunnel mode,
> +user could use "pgset spi SPI_VALUE" to specify which formal of 
> transformation
> +to employ.
> +
>

Thanks. Thats a good starting point. I just realized there's nothing at 
all on
ipsec ;-> Maybe you can add even more extensive info to describe all modes?

cheers,
jamal
>  Current commands and configuration options
>  ==========================================
> @@ -225,6 +239,7 @@ flag
>    UDPDST_RND
>    MACSRC_RND
>    MACDST_RND
> +  IPSEC
>
>  dst_min
>
>

  reply	other threads:[~2013-12-17 13:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15  7:57 [PATCHv3 net-next 0/7] pktgen IPsec support Fan Du
2013-12-15  7:57 ` [PATCHv3 net-next 1/7] {pktgen, xfrm} Correct xfrm state lock usage when transforming Fan Du
2013-12-15  7:57 ` [PATCHv3 net-next 2/7] {pktgen, xfrm} Add statistics counting " Fan Du
2013-12-15  7:58 ` [PATCHv3 net-next 3/7] {pktgen, xfrm} Correct xfrm_state_lock usage in xfrm_stateonly_find Fan Du
2013-12-15  7:58 ` [PATCHv3 net-next 4/7] {pktgen, xfrm} Using "pgset spi xxx" to spedifiy SA for a given flow Fan Du
2013-12-15  7:58 ` [PATCHv3 net-next 5/7] {pktgen, xfrm} Construct skb dst for tunnel mode transformation Fan Du
2013-12-15  7:58 ` [PATCHv3 net-next 6/7] {pktgen, xfrm} Introduce xfrm_state_lookup_byspi for pktgen Fan Du
2013-12-15 20:42   ` Sergei Shtylyov
2013-12-16 11:38     ` Fan Du
2013-12-15  7:58 ` [PATCHv3 net-next 7/7] {pktgen, xfrm} Show spi value properly when ipsec turned on Fan Du
2013-12-16 12:41 ` [PATCHv3 net-next 0/7] pktgen IPsec support Jamal Hadi Salim
2013-12-17  2:22   ` Fan Du
2013-12-17 13:41     ` jamal [this message]
2013-12-18  1:48       ` Fan Du
2013-12-18 13:41         ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B05482.7030400@gmail.com \
    --to=j.hadi123@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fan.du@windriver.com \
    --cc=hadi@cyberus.ca \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).