* [PATCH net-next] netfilter: ipvs: remove the unused variable
@ 2013-12-19 2:23 Wang Weidong
2013-12-19 7:17 ` Julian Anastasov
0 siblings, 1 reply; 4+ messages in thread
From: Wang Weidong @ 2013-12-19 2:23 UTC (permalink / raw)
To: wensong, horms, ja, David Miller; +Cc: netdev
when I built the netfilter, I got that:
net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/netfilter/ipvs/ip_vs_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index f63c238..d258125 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
continue;
}
while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
- int ret = __wait_event_interruptible(*sk_sleep(sk),
+ __wait_event_interruptible(*sk_sleep(sk),
sock_writeable(sk) ||
kthread_should_stop());
if (unlikely(kthread_should_stop()))
--
1.7.12
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: ipvs: remove the unused variable
2013-12-19 2:23 [PATCH net-next] netfilter: ipvs: remove the unused variable Wang Weidong
@ 2013-12-19 7:17 ` Julian Anastasov
2013-12-19 8:00 ` Wang Weidong
2013-12-27 3:21 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Julian Anastasov @ 2013-12-19 7:17 UTC (permalink / raw)
To: Wang Weidong; +Cc: wensong, horms, David Miller, netdev
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1237 bytes --]
Hello,
On Thu, 19 Dec 2013, Wang Weidong wrote:
> when I built the netfilter, I got that:
> net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
> net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’
There is another patch that we plan to apply but
due to possible merge conflict it was delayed:
http://marc.info/?t=138426695600002&r=1&w=2
http://marc.info/?t=138426469400008&r=1&w=2
May be it is time to apply it...
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/netfilter/ipvs/ip_vs_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index f63c238..d258125 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
> continue;
> }
> while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
> - int ret = __wait_event_interruptible(*sk_sleep(sk),
> + __wait_event_interruptible(*sk_sleep(sk),
> sock_writeable(sk) ||
> kthread_should_stop());
> if (unlikely(kthread_should_stop()))
> --
> 1.7.12
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: ipvs: remove the unused variable
2013-12-19 7:17 ` Julian Anastasov
@ 2013-12-19 8:00 ` Wang Weidong
2013-12-27 3:21 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Wang Weidong @ 2013-12-19 8:00 UTC (permalink / raw)
To: Julian Anastasov; +Cc: wensong, horms, David Miller, netdev
On 2013/12/19 15:17, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 19 Dec 2013, Wang Weidong wrote:
>
>> when I built the netfilter, I got that:
>> net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
>> net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’
>
> There is another patch that we plan to apply but
> due to possible merge conflict it was delayed:
>
> http://marc.info/?t=138426695600002&r=1&w=2
> http://marc.info/?t=138426469400008&r=1&w=2
>
> May be it is time to apply it...
>
Ok, Got it.
Regards.
Wang
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>> ---
>> net/netfilter/ipvs/ip_vs_sync.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
>> index f63c238..d258125 100644
>> --- a/net/netfilter/ipvs/ip_vs_sync.c
>> +++ b/net/netfilter/ipvs/ip_vs_sync.c
>> @@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
>> continue;
>> }
>> while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
>> - int ret = __wait_event_interruptible(*sk_sleep(sk),
>> + __wait_event_interruptible(*sk_sleep(sk),
>> sock_writeable(sk) ||
>> kthread_should_stop());
>> if (unlikely(kthread_should_stop()))
>> --
>> 1.7.12
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: ipvs: remove the unused variable
2013-12-19 7:17 ` Julian Anastasov
2013-12-19 8:00 ` Wang Weidong
@ 2013-12-27 3:21 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-12-27 3:21 UTC (permalink / raw)
To: Julian Anastasov; +Cc: Wang Weidong, wensong, David Miller, netdev
On Thu, Dec 19, 2013 at 09:17:17AM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 19 Dec 2013, Wang Weidong wrote:
>
> > when I built the netfilter, I got that:
> > net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
> > net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’
>
> There is another patch that we plan to apply but
> due to possible merge conflict it was delayed:
>
> http://marc.info/?t=138426695600002&r=1&w=2
> http://marc.info/?t=138426469400008&r=1&w=2
>
> May be it is time to apply it...
Thanks, I have done so.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-27 3:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 2:23 [PATCH net-next] netfilter: ipvs: remove the unused variable Wang Weidong
2013-12-19 7:17 ` Julian Anastasov
2013-12-19 8:00 ` Wang Weidong
2013-12-27 3:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).