* [PATCH] packet: doc: add documentation for VLAN TPID delivery
@ 2013-12-20 14:12 Atzm Watanabe
2013-12-20 15:10 ` Daniel Borkmann
2013-12-21 5:01 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Atzm Watanabe @ 2013-12-20 14:12 UTC (permalink / raw)
To: netdev
Introduce TP_STATUS_VLAN_TPID_VALID bit into the documentation.
Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
---
In the PACKET_MMAP, TP_STATUS_VLAN_VALID seems to be not
available in the V1, so I moved it into the V2.
Documentation/networking/packet_mmap.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/packet_mmap.txt b/Documentation/networking/packet_mmap.txt
index 4288ffa..723bf3d 100644
--- a/Documentation/networking/packet_mmap.txt
+++ b/Documentation/networking/packet_mmap.txt
@@ -517,8 +517,6 @@ where 'tpacket_version' can be TPACKET_V1 (default), TPACKET_V2, TPACKET_V3.
TPACKET_V1:
- Default if not otherwise specified by setsockopt(2)
- RX_RING, TX_RING available
- - VLAN metadata information available for packets
- (TP_STATUS_VLAN_VALID)
TPACKET_V1 --> TPACKET_V2:
- Made 64 bit clean due to unsigned long usage in TPACKET_V1
@@ -526,6 +524,13 @@ TPACKET_V1 --> TPACKET_V2:
userspace and the like
- Timestamp resolution in nanoseconds instead of microseconds
- RX_RING, TX_RING available
+ - VLAN metadata information available for packets
+ (TP_STATUS_VLAN_VALID, TP_STATUS_VLAN_TPID_VALID),
+ in the tpacket2_hdr structure:
+ - TP_STATUS_VLAN_VALID bit being set into the tp_status field indicates
+ that the tp_vlan_tci field has valid VLAN TCI value
+ - TP_STATUS_VLAN_TPID_VALID bit being set into the tp_status field
+ indicates that the tp_vlan_tpid field has valid VLAN TPID value
- How to switch to TPACKET_V2:
1. Replace struct tpacket_hdr by struct tpacket2_hdr
2. Query header len and save
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] packet: doc: add documentation for VLAN TPID delivery
2013-12-20 14:12 [PATCH] packet: doc: add documentation for VLAN TPID delivery Atzm Watanabe
@ 2013-12-20 15:10 ` Daniel Borkmann
2013-12-20 21:13 ` Daniel Borkmann
2013-12-21 5:01 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2013-12-20 15:10 UTC (permalink / raw)
To: Atzm Watanabe; +Cc: netdev
On 12/20/2013 03:12 PM, Atzm Watanabe wrote:
> Introduce TP_STATUS_VLAN_TPID_VALID bit into the documentation.
>
> Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Thanks !
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] packet: doc: add documentation for VLAN TPID delivery
2013-12-20 15:10 ` Daniel Borkmann
@ 2013-12-20 21:13 ` Daniel Borkmann
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2013-12-20 21:13 UTC (permalink / raw)
To: Atzm Watanabe; +Cc: netdev
On 12/20/2013 04:10 PM, Daniel Borkmann wrote:
> On 12/20/2013 03:12 PM, Atzm Watanabe wrote:
>> Introduce TP_STATUS_VLAN_TPID_VALID bit into the documentation.
>>
>> Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
(Intended for net-next since the subject doesn't say it.)
> Thanks !
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] packet: doc: add documentation for VLAN TPID delivery
2013-12-20 14:12 [PATCH] packet: doc: add documentation for VLAN TPID delivery Atzm Watanabe
2013-12-20 15:10 ` Daniel Borkmann
@ 2013-12-21 5:01 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-12-21 5:01 UTC (permalink / raw)
To: atzm; +Cc: netdev
From: Atzm Watanabe <atzm@stratosphere.co.jp>
Date: Fri, 20 Dec 2013 23:12:20 +0900
> Introduce TP_STATUS_VLAN_TPID_VALID bit into the documentation.
>
> Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-21 5:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 14:12 [PATCH] packet: doc: add documentation for VLAN TPID delivery Atzm Watanabe
2013-12-20 15:10 ` Daniel Borkmann
2013-12-20 21:13 ` Daniel Borkmann
2013-12-21 5:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).