* [PATCH net-next] sctp: fix missing include file
@ 2013-12-21 2:51 Scott Feldman
2013-12-21 5:00 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Scott Feldman @ 2013-12-21 2:51 UTC (permalink / raw)
To: vyasevich, nhorman; +Cc: netdev, roopa, shm
Compile error reported by Jim Davis on netdev.
ip6_sk_accept_pmtu() needs net/ip6_route.h
Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
---
net/sctp/input.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index 042ec6c..479ee19 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -48,6 +48,7 @@
#include <linux/time.h> /* For struct timeval */
#include <linux/slab.h>
#include <net/ip.h>
+#include <net/ip6_route.h>
#include <net/icmp.h>
#include <net/snmp.h>
#include <net/sock.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 2:51 [PATCH net-next] sctp: fix missing include file Scott Feldman
@ 2013-12-21 5:00 ` David Miller
2013-12-21 9:44 ` Daniel Borkmann
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2013-12-21 5:00 UTC (permalink / raw)
To: sfeldma; +Cc: vyasevich, nhorman, netdev, roopa, shm
From: Scott Feldman <sfeldma@cumulusnetworks.com>
Date: Fri, 20 Dec 2013 18:51:10 -0800
> Compile error reported by Jim Davis on netdev.
>
> ip6_sk_accept_pmtu() needs net/ip6_route.h
>
> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 5:00 ` David Miller
@ 2013-12-21 9:44 ` Daniel Borkmann
2013-12-21 15:19 ` Scott Feldman
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Borkmann @ 2013-12-21 9:44 UTC (permalink / raw)
To: David Miller
Cc: sfeldma, vyasevich, nhorman, netdev, roopa, shm,
Hannes Frederic Sowa, linux-sctp@vger.kernel.org
On 12/21/2013 06:00 AM, David Miller wrote:
> From: Scott Feldman <sfeldma@cumulusnetworks.com>
> Date: Fri, 20 Dec 2013 18:51:10 -0800
>
>> Compile error reported by Jim Davis on netdev.
>>
>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>
>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>
> Applied, thanks.
Sorry for the late reply as I'm on travel with limited connectivity.
Scott, this fix is not correct, and probably should be reverted. The
correct one was already in patchwork under [1]. In SCTP, we have
net/sctp/ipv6.c for all IPv6 related functions. Also there, this
include file is already present.
Thanks !
[1] http://patchwork.ozlabs.org/patch/303308/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 9:44 ` Daniel Borkmann
@ 2013-12-21 15:19 ` Scott Feldman
2013-12-22 3:01 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Scott Feldman @ 2013-12-21 15:19 UTC (permalink / raw)
To: Daniel Borkmann
Cc: David Miller, vyasevich, nhorman, Netdev, Roopa Prabhu,
Shrijeet Mukherjee, Hannes Frederic Sowa,
linux-sctp@vger.kernel.org
On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
> On 12/21/2013 06:00 AM, David Miller wrote:
>> From: Scott Feldman <sfeldma@cumulusnetworks.com>
>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>>
>>> Compile error reported by Jim Davis on netdev.
>>>
>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>>
>>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>>
>> Applied, thanks.
>
> Sorry for the late reply as I'm on travel with limited connectivity.
>
> Scott, this fix is not correct, and probably should be reverted. The
> correct one was already in patchwork under [1]. In SCTP, we have
> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
> include file is already present.
>
> Thanks !
>
> [1] http://patchwork.ozlabs.org/patch/303308/
Oops, sorry, two ships passing, etc. I should have looked under patchwork first.
David, please revert my change ac0917f2 pending Daniel’s fix.
-scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 15:19 ` Scott Feldman
@ 2013-12-22 3:01 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-12-22 3:01 UTC (permalink / raw)
To: sfeldma
Cc: dborkman, vyasevich, nhorman, netdev, roopa, shm, hannes,
linux-sctp
From: Scott Feldman <sfeldma@cumulusnetworks.com>
Date: Sat, 21 Dec 2013 07:19:03 -0800
>
> On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
>
>> On 12/21/2013 06:00 AM, David Miller wrote:
>>> From: Scott Feldman <sfeldma@cumulusnetworks.com>
>>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>>>
>>>> Compile error reported by Jim Davis on netdev.
>>>>
>>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>>>
>>>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>>>
>>> Applied, thanks.
>>
>> Sorry for the late reply as I'm on travel with limited connectivity.
>>
>> Scott, this fix is not correct, and probably should be reverted. The
>> correct one was already in patchwork under [1]. In SCTP, we have
>> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
>> include file is already present.
>>
>> Thanks !
>>
>> [1] http://patchwork.ozlabs.org/patch/303308/
>
> Oops, sorry, two ships passing, etc. I should have looked under patchwork first.
>
> David, please revert my change ac0917f2 pending Daniel’s fix.
Done.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-22 3:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 2:51 [PATCH net-next] sctp: fix missing include file Scott Feldman
2013-12-21 5:00 ` David Miller
2013-12-21 9:44 ` Daniel Borkmann
2013-12-21 15:19 ` Scott Feldman
2013-12-22 3:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).