From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
Date: Sat, 21 Dec 2013 22:06:15 +0100 [thread overview]
Message-ID: <52B602C7.4080307@pengutronix.de> (raw)
In-Reply-To: <20131220213341.GA452@localhost>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On 12/20/2013 10:33 PM, Ezequiel Garcia wrote:
> On Sat, Dec 21, 2013 at 12:17:27AM +0300, Sergei Shtylyov wrote:
>> On 12/20/2013 11:14 PM, Ezequiel Garcia wrote:
>>
>>> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
>>> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
>>> the driver depend on ARM.
>>
>> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT'
>> to 'depends on ARCH_OMAP2PLUS'?
> Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail
> in v2). I'd say it's Marc's call.
Convinced, I've added the v1 of this patch to can-next together with a
|| COMIPLE_TEXT.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-12-21 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 20:14 [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency Ezequiel Garcia
2013-12-20 21:17 ` Sergei Shtylyov
2013-12-20 21:33 ` Ezequiel Garcia
2013-12-21 21:06 ` Marc Kleine-Budde [this message]
2013-12-21 22:16 ` Sergei Shtylyov
2013-12-21 21:32 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B602C7.4080307@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).