From: Or Gerlitz <ogerlitz@mellanox.com>
To: Joe Perches <joe@perches.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<amirv@mellanox.com>, <yanb@mellanox.com>, <ast@plumgrid.com>
Subject: Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling
Date: Sun, 22 Dec 2013 16:53:43 +0200 [thread overview]
Message-ID: <52B6FCF7.5010205@mellanox.com> (raw)
In-Reply-To: <1387721989.22671.16.camel@joe-AO722>
On 22/12/2013 16:19, Joe Perches wrote:
>> >+ if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> >+ dev->hw_enc_features = NETIF_F_SG | NETIF_F_IP_CSUM |
>> >+ NETIF_F_RXCSUM | NETIF_F_TSO |
>> >+ NETIF_F_GSO_UDP_TUNNEL;
>> >+ dev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
>> >+ dev->features |= NETIF_F_GSO_UDP_TUNNEL;
> Perhaps hw_enc_features should be |= as well.
> NETIF_F_SG is set in register_netdevice() for hw_enc_features.
>
OK, I'll do that, thanks for spotting this over.
prev parent reply other threads:[~2013-12-22 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 14:00 [PATCH net-next V1 0/2] net/mlx4: Add support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 14:00 ` [PATCH net-next V1 1/2] net/mlx4_core: Add basic support for TCP/IP offloads under tunneling Or Gerlitz
2013-12-22 14:00 ` [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 14:19 ` Joe Perches
2013-12-22 14:45 ` Or Gerlitz
2013-12-22 14:52 ` Joe Perches
2013-12-22 15:05 ` Or Gerlitz
2013-12-22 14:53 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B6FCF7.5010205@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox