From: Or Gerlitz <ogerlitz@mellanox.com>
To: Joe Perches <joe@perches.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<amirv@mellanox.com>, <yanb@mellanox.com>, <ast@plumgrid.com>,
Matan Barak <matanb@mellanox.com>
Subject: Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling
Date: Sun, 22 Dec 2013 17:05:58 +0200 [thread overview]
Message-ID: <52B6FFD6.1010105@mellanox.com> (raw)
In-Reply-To: <1387723973.22671.19.camel@joe-AO722>
On 22/12/2013 16:52, Joe Perches wrote:
> On Sun, 2013-12-22 at 16:45 +0200, Or Gerlitz wrote:
>> On 22/12/2013 16:19, Joe Perches wrote:
>>> On Sun, 2013-12-22 at 16:00 +0200, Or Gerlitz wrote:
>>> trivia:
> []
>>>> @@ -68,6 +68,12 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride,
>>>> context->db_rec_addr = cpu_to_be64(priv->res.db.dma << 2);
>>>> if (!(dev->features & NETIF_F_HW_VLAN_CTAG_RX))
>>>> context->param3 |= cpu_to_be32(1 << 30);
>>>> +
>>>> + if (!is_tx && !rss &&
>>>> + (mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>>>> + en_dbg(HW, priv, "Setting RX qp %x tunnel mode to RX tunneled & non-tunneled\n", qpn);
>>>> + context->srqn |= cpu_to_be32(7 << 28); /* this fills bits 30:28 */
>>> Is that bit setting 0 based or 1 based?
>> 1 based, any issue with that?
> No, but if it's 1 based, doesn't this fill bits 31:29 ?
oops, sorry, I was wrongly reading your question... the setting is 0
index based, and hence we fill bits 30:28
next prev parent reply other threads:[~2013-12-22 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 14:00 [PATCH net-next V1 0/2] net/mlx4: Add support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 14:00 ` [PATCH net-next V1 1/2] net/mlx4_core: Add basic support for TCP/IP offloads under tunneling Or Gerlitz
2013-12-22 14:00 ` [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 14:19 ` Joe Perches
2013-12-22 14:45 ` Or Gerlitz
2013-12-22 14:52 ` Joe Perches
2013-12-22 15:05 ` Or Gerlitz [this message]
2013-12-22 14:53 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B6FFD6.1010105@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox