Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling

Or Gerlitz
2013-12-22T15:03:14Z

On 22/12/2013 16:19, Joe Perches wrote:
>> >+ if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>> >+ dev->hw_enc_features = NETIF_F_SG | NETIF_F_IP_CSUM |
>> >+ NETIF_F_RXCSUM | NETIF_F_TSO |
>> >+ NETIF_F_GSO_UDP_TUNNEL;
>> >+ dev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
>> >+ dev->features |= NETIF_F_GSO_UDP_TUNNEL;
> Perhaps hw_enc_features should be |= as well.
> NETIF_F_SG is set in register_netdevice() for hw_enc_features.
>

OK, I'll do that, thanks for spotting this over.