Re: [PATCH net-next V1 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling

Or Gerlitz
2013-12-22T15:13:12Z

On 22/12/2013 16:52, Joe Perches wrote:
> On Sun, 2013-12-22 at 16:45 +0200, Or Gerlitz wrote:
>> On 22/12/2013 16:19, Joe Perches wrote:
>>> On Sun, 2013-12-22 at 16:00 +0200, Or Gerlitz wrote:
>>> trivia:
> []
>>>> @@ -68,6 +68,12 @@ void mlx4_en_fill_qp_context(struct mlx4_en_priv *priv, int size, int stride,
>>>> context->db_rec_addr = cpu_to_be64(priv->res.db.dma << 2);
>>>> if (!(dev->features & NETIF_F_HW_VLAN_CTAG_RX))
>>>> context->param3 |= cpu_to_be32(1 << 30);
>>>> +
>>>> + if (!is_tx && !rss &&
>>>> + (mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>>>> + en_dbg(HW, priv, "Setting RX qp %x tunnel mode to RX tunneled & non-tunneled\n", qpn);
>>>> + context->srqn |= cpu_to_be32(7 << 28); /* this fills bits 30:28 */
>>> Is that bit setting 0 based or 1 based?
>> 1 based, any issue with that?
> No, but if it's 1 based, doesn't this fill bits 31:29 ?

oops, sorry, I was wrongly reading your question... the setting is 0
index based, and hence we fill bits 30:28