From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, darkjames-ws@darkjames.pl
Subject: Re: [PATCH net-next 2/2] netlink: specify netlink packet direction for nlmon
Date: Mon, 23 Dec 2013 01:06:24 +0100 [thread overview]
Message-ID: <52B77E80.3010205@redhat.com> (raw)
In-Reply-To: <20131222.185628.593979257362137672.davem@davemloft.net>
On 12/23/2013 12:56 AM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Thu, 19 Dec 2013 02:29:39 +0100
>
>> @@ -29,6 +29,9 @@ struct sockaddr_ll {
>> /* These ones are invisible by user level */
>> #define PACKET_LOOPBACK 5 /* MC/BRD frame looped back */
>> #define PACKET_FASTROUTE 6 /* Fastrouted frame */
>> +/* These ones are for nlmon devices */
>> +#define PACKET_USER 0 /* To user space */
>> +#define PACKET_KERNEL 1 /* To kernel space */
>
> I know it is tempting to do so, but please do not reuse values
> like this.
Hm, ok. As we only have 3 bits for all this, are you okay with
doing the following ...
#define PACKET_USER 6 /* To user space */
#define PACKET_KERNEL 7 /* To kernel space */
PACKET_FASTROUTE isn't used anywhere in the tree, only defined
in this header file. Then, by doing this, we would still fit.
> THanks.
prev parent reply other threads:[~2013-12-23 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 1:29 [PATCH net-next 0/2] nlmon updates Daniel Borkmann
2013-12-19 1:29 ` [PATCH net-next 1/2] netlink: only do not deliver to tap when both sides are kernel sks Daniel Borkmann
2013-12-19 1:29 ` [PATCH net-next 2/2] netlink: specify netlink packet direction for nlmon Daniel Borkmann
2013-12-22 23:56 ` David Miller
2013-12-23 0:06 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B77E80.3010205@redhat.com \
--to=dborkman@redhat.com \
--cc=darkjames-ws@darkjames.pl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).