From: Yang Yingliang <yangyingliang@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH resend net-next 1/2] net_sched: replace pr_warning with pr_warn
Date: Mon, 23 Dec 2013 15:39:56 +0800 [thread overview]
Message-ID: <52B7E8CC.50605@huawei.com> (raw)
In-Reply-To: <1387761616.22671.40.camel@joe-AO722>
On 2013/12/23 9:20, Joe Perches wrote:
> On Mon, 2013-12-23 at 09:06 +0800, Yang Yingliang wrote:
>> Prefer pr_warn(... to pr_warning(...
>
> Couple of trivial comments:
>
>> diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c
> []
>> @@ -303,8 +303,8 @@ static struct sk_buff *dsmark_dequeue(struct Qdisc *sch)
>> * and don't need yet another qdisc as a bypass.
>> */
>> if (p->mask[index] != 0xff || p->value[index])
>> - pr_warning("dsmark_dequeue: unsupported protocol %d\n",
>> - ntohs(skb->protocol));
>> + pr_warn("dsmark_dequeue: unsupported protocol %d\n",
>> + ntohs(skb->protocol));
>
> When converting messages with embedded function names,
> consider using "%s: ...", __func__
>
>> diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
> []
>> @@ -370,8 +370,8 @@ static inline int gred_change_table_def(struct Qdisc *sch, struct nlattr *dps)
>>
>> for (i = table->DPs; i < MAX_DPs; i++) {
>> if (table->tab[i]) {
>> - pr_warning("GRED: Warning: Destroying "
>> - "shadowed VQ 0x%x\n", i);
>> + pr_warn("GRED: Warning: Destroying "
>> + "shadowed VQ 0x%x\n", i);
>
> When converting formats split across multiple lines,
> please coalesce the format fragments like:
>
> pr_warn("GRED: Warning: Destroying shadowed V0 0x%x\n",
> i);
>
>
>
>
OK, thanks!
next prev parent reply other threads:[~2013-12-23 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 1:06 [PATCH resend net-next 0/2] net_sched: do some cleanup Yang Yingliang
2013-12-23 1:06 ` [PATCH resend net-next 1/2] net_sched: replace pr_warning with pr_warn Yang Yingliang
2013-12-23 1:20 ` Joe Perches
2013-12-23 7:39 ` Yang Yingliang [this message]
2013-12-23 1:06 ` [PATCH resend net-next 2/2] sch_htb: use /* comments Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7E8CC.50605@huawei.com \
--to=yangyingliang@huawei.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).