From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>
Cc: Ding Tianhong <dingtianhong@huawei.com>,
Michal Ostrowski <mostrows@earthlink.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 06/20] ppp: slight optimization of addr compare
Date: Tue, 24 Dec 2013 20:40:46 +0400 [thread overview]
Message-ID: <52B9B90E.6040106@cogentembedded.com> (raw)
In-Reply-To: <1387902949.2259.51.camel@joe-AO722>
Hello.
On 24-12-2013 20:35, Joe Perches wrote:
> []
>>> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> []
>>> @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
>>>
>>> static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
>>> {
>>> - return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
>>> + return a->sid == b->sid && ether_addr_equal(a->remote,
>>> + b->remote);
>> If it really doesn't fit insto single line, the continuation line should
>> start right under 'a->remote'.
> Better still might be
>
> return a->sid == b->sid &&
> ether_addr_equal(a->remote, b->remote);
Actually, after the second look, I don't know why the line was broken at all.
WBR, Sergei
prev parent reply other threads:[~2013-12-24 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 11:28 [PATCH v2 06/20] ppp: slight optimization of addr compare Ding Tianhong
2013-12-24 16:24 ` Sergei Shtylyov
2013-12-24 16:35 ` Joe Perches
2013-12-24 16:40 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B9B90E.6040106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dingtianhong@huawei.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).