From: Wang Weidong <wangweidong1@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <jon.maloy@ericsson.com>, <allan.stephens@windriver.com>,
<David.Laight@ACULAB.COM>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] tipc: do some fixups
Date: Wed, 25 Dec 2013 09:33:04 +0800 [thread overview]
Message-ID: <52BA35D0.7060003@huawei.com> (raw)
In-Reply-To: <20131224.174541.2213038026686672610.davem@davemloft.net>
On 2013/12/25 6:45, David Miller wrote:
>
> Referring to commit purely by SHA1 ID is ambiguous.
>
> If the change is placed in other trees, such as the -stable
> branches, they will have different SHA1 IDs.
>
> This is why you must always refer to commits as the
> SHA1 ID followed by the commit header line text of
> the commit in parenthesis and double quotes, like
> this:
>
> Commit 0cee6bbe06f ("tipc: remove unnecessary variables and conditions")
>
> Please fix this up in this entire patch series and resubmit.
>
Ok, I will fix them.
Regards.
Wang
>
prev parent reply other threads:[~2013-12-25 1:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 7:03 [PATCH net-next 0/2] tipc: do some fixups Wang Weidong
2013-12-17 7:03 ` [PATCH net-next 1/2] tipc: make the code look more better Wang Weidong
2013-12-17 7:03 ` [PATCH net-next 2/2] tipc: make the code look more readability Wang Weidong
2013-12-27 1:45 ` [PATCH net-next v3 2/2] tipc: make the code look more readable Wang Weidong
2013-12-27 1:51 ` Ying Xue
2013-12-27 1:59 ` Wang Weidong
2013-12-27 4:04 ` David Miller
2013-12-27 2:09 ` [PATCH net-next RESEND v3] " Wang Weidong
2013-12-27 4:04 ` David Miller
2013-12-27 4:21 ` Wang Weidong
2013-12-24 22:45 ` [PATCH net-next 0/2] tipc: do some fixups David Miller
2013-12-25 1:33 ` Wang Weidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BA35D0.7060003@huawei.com \
--to=wangweidong1@huawei.com \
--cc=David.Laight@ACULAB.COM \
--cc=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).