Re: [PATCH net-next] bridge: remove extern from function prototypes

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 26-12-2013 10:19, Duan Jiong wrote:

> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.

> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.

> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
>   net/bridge/br_private.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 2e77d92..458889e 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -762,7 +762,7 @@ unsigned long br_timer_value(const struct timer_list *timer);
>   
>   /* br.c */
>   #if IS_ENABLED(CONFIG_ATM_LANE)
> -extern int (*br_fdb_test_addr_hook)(struct net_device *dev, unsigned char *addr);
> +int (*br_fdb_test_addr_hook)(struct net_device *dev, unsigned char *addr);

   This is not a function prototype, this is a pointer to function, so
removing *extern* is not right.

>   #endif

WBR, Sergei