* [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare
@ 2013-12-26 11:41 Ding Tianhong
2013-12-26 12:47 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Ding Tianhong @ 2013-12-26 11:41 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, John W. Linville, linux-wireless,
Netdev, linux-kernel@vger.kernel.org
Use possibly more efficient ether_addr_equal_unaligned
instead of memcmp.
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/wireless/rtlwifi/cam.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
index 0e510f7..0276153 100644
--- a/drivers/net/wireless/rtlwifi/cam.c
+++ b/drivers/net/wireless/rtlwifi/cam.c
@@ -295,7 +295,7 @@ u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, u8 *sta_addr)
/* Does STA already exist? */
for (i = 4; i < TOTAL_CAM_ENTRY; i++) {
addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
- if (memcmp(addr, sta_addr, ETH_ALEN) == 0)
+ if (ether_addr_equal_unaligned(addr, sta_addr))
return i;
}
/* Get a free CAM entry. */
@@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
if (((bitmap & BIT(0)) == BIT(0)) &&
- (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
+ (ether_addr_equal_unaligned(addr, sta_addr))) {
/* Remove from HW Security CAM */
eth_zero_addr(rtlpriv->sec.hwsec_cam_sta_addr[i]);
rtlpriv->sec.hwsec_cam_bitmap &= ~(BIT(0) << i);
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare
2013-12-26 11:41 [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare Ding Tianhong
@ 2013-12-26 12:47 ` Sergei Shtylyov
2014-01-06 19:53 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2013-12-26 12:47 UTC (permalink / raw)
To: Ding Tianhong, Larry Finger, Chaoming Li, John W. Linville,
linux-wireless, Netdev, linux-kernel@vger.kernel.org
Hello.
On 26-12-2013 15:41, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal_unaligned
> instead of memcmp.
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Chaoming Li <chaoming_li@realsil.com.cn>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> ---
> drivers/net/wireless/rtlwifi/cam.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> index 0e510f7..0276153 100644
> --- a/drivers/net/wireless/rtlwifi/cam.c
> +++ b/drivers/net/wireless/rtlwifi/cam.c
[...]
> @@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
> addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
> bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
> if (((bitmap & BIT(0)) == BIT(0)) &&
> - (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
> + (ether_addr_equal_unaligned(addr, sta_addr))) {
It's pointless to enclose function call in parens, again.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare
2013-12-26 12:47 ` Sergei Shtylyov
@ 2014-01-06 19:53 ` John W. Linville
2014-01-06 20:51 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: John W. Linville @ 2014-01-06 19:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Ding Tianhong, Larry Finger, Chaoming Li, linux-wireless, Netdev,
linux-kernel@vger.kernel.org
On Thu, Dec 26, 2013 at 04:47:50PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 26-12-2013 15:41, Ding Tianhong wrote:
>
> >Use possibly more efficient ether_addr_equal_unaligned
> >instead of memcmp.
>
> >Cc: Larry Finger <Larry.Finger@lwfinger.net>
> >Cc: Chaoming Li <chaoming_li@realsil.com.cn>
> >Cc: John W. Linville <linville@tuxdriver.com>
> >Cc: linux-wireless@vger.kernel.org
> >Cc: netdev@vger.kernel.org
> >Cc: linux-kernel@vger.kernel.org
> >Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> >Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> >---
> > drivers/net/wireless/rtlwifi/cam.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> >diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> >index 0e510f7..0276153 100644
> >--- a/drivers/net/wireless/rtlwifi/cam.c
> >+++ b/drivers/net/wireless/rtlwifi/cam.c
> [...]
> >@@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
> > addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
> > bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
> > if (((bitmap & BIT(0)) == BIT(0)) &&
> >- (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
> >+ (ether_addr_equal_unaligned(addr, sta_addr))) {
>
> It's pointless to enclose function call in parens, again.
I'll correct that issue when merging the patch.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare
2014-01-06 19:53 ` John W. Linville
@ 2014-01-06 20:51 ` John W. Linville
0 siblings, 0 replies; 4+ messages in thread
From: John W. Linville @ 2014-01-06 20:51 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Ding Tianhong, Larry Finger, Chaoming Li, linux-wireless, Netdev,
linux-kernel@vger.kernel.org
On Mon, Jan 06, 2014 at 02:53:02PM -0500, John W. Linville wrote:
> On Thu, Dec 26, 2013 at 04:47:50PM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 26-12-2013 15:41, Ding Tianhong wrote:
> >
> > >Use possibly more efficient ether_addr_equal_unaligned
> > >instead of memcmp.
> >
> > >Cc: Larry Finger <Larry.Finger@lwfinger.net>
> > >Cc: Chaoming Li <chaoming_li@realsil.com.cn>
> > >Cc: John W. Linville <linville@tuxdriver.com>
> > >Cc: linux-wireless@vger.kernel.org
> > >Cc: netdev@vger.kernel.org
> > >Cc: linux-kernel@vger.kernel.org
> > >Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> > >Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> > >---
> > > drivers/net/wireless/rtlwifi/cam.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > >diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
> > >index 0e510f7..0276153 100644
> > >--- a/drivers/net/wireless/rtlwifi/cam.c
> > >+++ b/drivers/net/wireless/rtlwifi/cam.c
> > [...]
> > >@@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
> > > addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
> > > bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
> > > if (((bitmap & BIT(0)) == BIT(0)) &&
> > >- (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
> > >+ (ether_addr_equal_unaligned(addr, sta_addr))) {
> >
> > It's pointless to enclose function call in parens, again.
>
> I'll correct that issue when merging the patch.
Well, that was the plan... But since ether_addr_equal_unaligned
isn't in the wireless trees at the moment, it will have to wait or go
through another tree that has that definition. Feel free to respin
with the extra parenthesis removed...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-06 20:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-26 11:41 [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare Ding Tianhong
2013-12-26 12:47 ` Sergei Shtylyov
2014-01-06 19:53 ` John W. Linville
2014-01-06 20:51 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).