From: Ding Tianhong <dingtianhong@huawei.com>
To: "David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH net-next 19/20] net: plip: slight optimization of addr compare
Date: Fri, 27 Dec 2013 14:49:17 +0800 [thread overview]
Message-ID: <52BD22ED.4030302@huawei.com> (raw)
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index 7b4ff35..26614df 100644
--- a/drivers/net/plip/plip.c
+++ b/drivers/net/plip/plip.c
@@ -549,7 +549,7 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct net_device *dev)
if(*eth->h_dest&1)
{
- if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0)
+ if(ether_addr_equal(eth->h_dest, dev->broadcast))
skb->pkt_type=PACKET_BROADCAST;
else
skb->pkt_type=PACKET_MULTICAST;
--
1.8.0
next reply other threads:[~2013-12-27 6:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 6:49 Ding Tianhong [this message]
2013-12-27 15:48 ` [PATCH net-next 19/20] net: plip: slight optimization of addr compare Eric Dumazet
2013-12-27 17:06 ` Joe Perches
2013-12-27 20:12 ` Julia Lawall
2013-12-27 20:46 ` Joe Perches
2013-12-27 21:56 ` [PATCH] i40e: use ether_addr_equal_64bits Joe Perches
2013-12-27 21:59 ` Jeff Kirsher
2013-12-27 22:47 ` [PATCH net-next 19/20] net: plip: slight optimization of addr compare Julia Lawall
2013-12-29 22:05 ` Julia Lawall
2013-12-29 22:28 ` Joe Perches
2013-12-28 5:07 ` Ding Tianhong
2013-12-28 5:11 ` Joe Perches
2013-12-28 5:35 ` Ding Tianhong
2013-12-28 5:05 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BD22ED.4030302@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).