Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare

Joe Perches
2013-12-28T06:59:13Z

On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.

This may be a distinction without difference, but
is a CAIF seghead also an ethernet address?

> diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
[]
> @@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct cfrfml *rfml, char *seghead,
[]
> /* Verify correct header */
> - if (memcmp(seghead, rfml->seghead, 6) != 0)
> + if (!ether_addr_equal(seghead, rfml->seghead))