Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare

Joe Perches
2013-12-28T17:04:31Z

On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
> 于 2013/12/28 14:59, Joe Perches 写道:
> > On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
> >> Use possibly more efficient ether_addr_equal
> >> to instead of memcmp.
> >
> > This may be a distinction without difference, but
> > is a CAIF seghead also an ethernet address?
> >
> NO，this is a coincidence, the CAIF seghead is 6 bytes too,
> So from a logical point of view, maybe a new function with
> suitable name will be more reasonable here, but the name of
> ether_addr_equal is not correctly here.:)

So please remove this one from the series.