netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2] dont skip action order
@ 2013-12-22 15:37 Jamal Hadi Salim
  2013-12-28 19:01 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Jamal Hadi Salim @ 2013-12-22 15:37 UTC (permalink / raw)
  To: Stephen Hemminger, netdev@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]


attached.

cheers,
jamal

[-- Attachment #2: dont-skip-action-order-index --]
[-- Type: text/plain, Size: 1037 bytes --]

commit 58d78f9f6447df324cdeb99262442c5e3f1f924b
Author: Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Sun Dec 22 10:34:18 2013 -0500

    dont skip displaying of action chains or lists by TCA_ACT_MAX_PRIO
    
    Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

diff --git a/tc/m_action.c b/tc/m_action.c
index 51085ec..77479d6 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -32,7 +32,6 @@ static struct action_util * action_list;
 #ifdef CONFIG_GACT
 int gact_ld = 0 ; //fuckin backward compatibility
 #endif
-int batch_c = 0;
 int tab_flush = 0;
 
 static void act_usage(void)
@@ -304,7 +303,7 @@ tc_print_action(FILE * f, const struct rtattr *arg)
 
 	for (i = 0; i < TCA_ACT_MAX_PRIO; i++) {
 		if (tb[i]) {
-			fprintf(f, "\n\taction order %d: ", i + batch_c);
+			fprintf(f, "\n\taction order %d: ", i);
 			if (0 > tc_print_one_action(f, tb[i])) {
 				fprintf(f, "Error printing action\n");
 			}
@@ -312,7 +311,6 @@ tc_print_action(FILE * f, const struct rtattr *arg)
 
 	}
 
-	batch_c+=TCA_ACT_MAX_PRIO ;
 	return 0;
 }
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] dont skip action order
  2013-12-22 15:37 [PATCH iproute2] dont skip action order Jamal Hadi Salim
@ 2013-12-28 19:01 ` Stephen Hemminger
  2014-01-01 16:46   ` Jamal Hadi Salim
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2013-12-28 19:01 UTC (permalink / raw)
  To: Jamal Hadi Salim; +Cc: netdev@vger.kernel.org

On Sun, 22 Dec 2013 10:37:44 -0500
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> 
> attached.
> 
> cheers,
> jamal

I applied all 8 patches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] dont skip action order
  2013-12-28 19:01 ` Stephen Hemminger
@ 2014-01-01 16:46   ` Jamal Hadi Salim
  0 siblings, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2014-01-01 16:46 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev@vger.kernel.org

On 12/28/13 14:01, Stephen Hemminger wrote:

> I applied all 8 patches

Thanks Stephen. I have one more - although it is not dependent
on the kernel patch for flush counter, that patch makes it better.
I will wait for Dave to take in the patch, test then send it to you.

cheers,
jamal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-01 16:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-22 15:37 [PATCH iproute2] dont skip action order Jamal Hadi Salim
2013-12-28 19:01 ` Stephen Hemminger
2014-01-01 16:46   ` Jamal Hadi Salim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).