* [PATCH net-next] sched action: make local function static
@ 2013-12-31 19:54 Stephen Hemminger
2014-01-01 16:48 ` Jamal Hadi Salim
2014-01-02 8:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2013-12-31 19:54 UTC (permalink / raw)
To: David Miller, Jamal Hadi Salim; +Cc: netdev
No need to export functions only used in one file.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/include/net/act_api.h 2013-12-30 21:34:18.394981566 -0800
+++ b/include/net/act_api.h 2013-12-30 21:34:51.862553923 -0800
@@ -105,10 +105,7 @@ struct tcf_common *tcf_hash_lookup(u32 i
void tcf_hash_destroy(struct tcf_common *p, struct tcf_hashinfo *hinfo);
int tcf_hash_release(struct tcf_common *p, int bind,
struct tcf_hashinfo *hinfo);
-int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
- int type, struct tc_action *a);
u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo);
-int tcf_hash_search(struct tc_action *a, u32 index);
struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a,
int bind, struct tcf_hashinfo *hinfo);
struct tcf_common *tcf_hash_create(u32 index, struct nlattr *est,
--- a/net/sched/act_api.c 2013-12-30 21:34:18.394981566 -0800
+++ b/net/sched/act_api.c 2013-12-30 21:34:51.862553923 -0800
@@ -141,8 +141,8 @@ nla_put_failure:
return -EINVAL;
}
-int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
- int type, struct tc_action *a)
+static int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
+ int type, struct tc_action *a)
{
struct tcf_hashinfo *hinfo = a->ops->hinfo;
@@ -155,7 +155,6 @@ int tcf_generic_walker(struct sk_buff *s
return -EINVAL;
}
}
-EXPORT_SYMBOL(tcf_generic_walker);
struct tcf_common *tcf_hash_lookup(u32 index, struct tcf_hashinfo *hinfo)
{
@@ -187,7 +186,7 @@ u32 tcf_hash_new_index(u32 *idx_gen, str
}
EXPORT_SYMBOL(tcf_hash_new_index);
-int tcf_hash_search(struct tc_action *a, u32 index)
+static int tcf_hash_search(struct tc_action *a, u32 index)
{
struct tcf_hashinfo *hinfo = a->ops->hinfo;
struct tcf_common *p = tcf_hash_lookup(index, hinfo);
@@ -198,7 +197,6 @@ int tcf_hash_search(struct tc_action *a,
}
return 0;
}
-EXPORT_SYMBOL(tcf_hash_search);
struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a, int bind,
struct tcf_hashinfo *hinfo)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sched action: make local function static
2013-12-31 19:54 [PATCH net-next] sched action: make local function static Stephen Hemminger
@ 2014-01-01 16:48 ` Jamal Hadi Salim
2014-01-02 8:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2014-01-01 16:48 UTC (permalink / raw)
To: Stephen Hemminger, David Miller; +Cc: netdev
On 12/31/13 14:54, Stephen Hemminger wrote:
> No need to export functions only used in one file.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sched action: make local function static
2013-12-31 19:54 [PATCH net-next] sched action: make local function static Stephen Hemminger
2014-01-01 16:48 ` Jamal Hadi Salim
@ 2014-01-02 8:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-02 8:32 UTC (permalink / raw)
To: stephen; +Cc: jhs, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 31 Dec 2013 11:54:00 -0800
> No need to export functions only used in one file.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-02 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-31 19:54 [PATCH net-next] sched action: make local function static Stephen Hemminger
2014-01-01 16:48 ` Jamal Hadi Salim
2014-01-02 8:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).