[PATCH net-next] sched action: make local function static

[PATCH net-next] sched action: make local function static

[Stephen Hemminger]

No need to export functions only used in one file.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/include/net/act_api.h	2013-12-30 21:34:18.394981566 -0800
+++ b/include/net/act_api.h	2013-12-30 21:34:51.862553923 -0800
@@ -105,10 +105,7 @@ struct tcf_common *tcf_hash_lookup(u32 i
 void tcf_hash_destroy(struct tcf_common *p, struct tcf_hashinfo *hinfo);
 int tcf_hash_release(struct tcf_common *p, int bind,
 		     struct tcf_hashinfo *hinfo);
-int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
-		       int type, struct tc_action *a);
 u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo);
-int tcf_hash_search(struct tc_action *a, u32 index);
 struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a,
 				  int bind, struct tcf_hashinfo *hinfo);
 struct tcf_common *tcf_hash_create(u32 index, struct nlattr *est,
--- a/net/sched/act_api.c	2013-12-30 21:34:18.394981566 -0800
+++ b/net/sched/act_api.c	2013-12-30 21:34:51.862553923 -0800
@@ -141,8 +141,8 @@ nla_put_failure:
 	return -EINVAL;
 }
 
-int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
-		       int type, struct tc_action *a)
+static int tcf_generic_walker(struct sk_buff *skb, struct netlink_callback *cb,
+			      int type, struct tc_action *a)
 {
 	struct tcf_hashinfo *hinfo = a->ops->hinfo;
 
@@ -155,7 +155,6 @@ int tcf_generic_walker(struct sk_buff *s
 		return -EINVAL;
 	}
 }
-EXPORT_SYMBOL(tcf_generic_walker);
 
 struct tcf_common *tcf_hash_lookup(u32 index, struct tcf_hashinfo *hinfo)
 {
@@ -187,7 +186,7 @@ u32 tcf_hash_new_index(u32 *idx_gen, str
 }
 EXPORT_SYMBOL(tcf_hash_new_index);
 
-int tcf_hash_search(struct tc_action *a, u32 index)
+static int tcf_hash_search(struct tc_action *a, u32 index)
 {
 	struct tcf_hashinfo *hinfo = a->ops->hinfo;
 	struct tcf_common *p = tcf_hash_lookup(index, hinfo);
@@ -198,7 +197,6 @@ int tcf_hash_search(struct tc_action *a,
 	}
 	return 0;
 }
-EXPORT_SYMBOL(tcf_hash_search);
 
 struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a, int bind,
 				  struct tcf_hashinfo *hinfo)

Re: [PATCH net-next] sched action: make local function static

[Jamal Hadi Salim]

On 12/31/13 14:54, Stephen Hemminger wrote:
> No need to export functions only used in one file.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

Re: [PATCH net-next] sched action: make local function static

[David Miller]

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 31 Dec 2013 11:54:00 -0800

> No need to export functions only used in one file.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied.